Skip to content

iproto: add new keys to Binary protocol page #3433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 13, 2023
Merged

Conversation

xuniq
Copy link
Contributor

@xuniq xuniq commented Apr 5, 2023

Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299

  1. Updated keys in General Replication section:
  • Added IPROTO_VCLOCK_SYNC key
  • Renamed IPROTO_CLUSTER_UUID key to IPROTO_REPLICASET_UUID
  • Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys
  1. Updated vclock keys description

  2. Updated description and svg for heartbeat messages (added IPROTO_VCLOCK_SYNC and IPROTO_TERM)

  3. Updated IPROTO_BALLOT description

  1. Updated IPROTO_TERM key description:
  1. Updated byte code examples for the heartbeat messages (added IPROTO_VCLOCK_SYNC and IPROTO_TERM)

@xuniq xuniq changed the base branch from latest to 2.11 April 5, 2023 09:22
@xuniq xuniq force-pushed the gh-3166-iproto-keys branch 2 times, most recently from 05cfa1c to 316ecfb Compare April 11, 2023 10:23
@xuniq xuniq marked this pull request as ready for review April 11, 2023 14:00
@xuniq xuniq force-pushed the gh-3166-iproto-keys branch from 7ee889a to 2d3ff19 Compare April 11, 2023 14:29
@xuniq xuniq requested a review from sergepetrenko April 11, 2023 14:38
Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

Looks good generally, please find a couple of comments below.

@xuniq xuniq force-pushed the gh-3166-iproto-keys branch from 2d3ff19 to 511e4d5 Compare April 13, 2023 08:59
Copy link
Contributor

@andreyaksenov andreyaksenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, found one broken link and added several minor suggestions.

Copy link
Contributor

@sergepetrenko sergepetrenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@xuniq xuniq merged commit 8607c8a into 2.11 Apr 13, 2023
@xuniq xuniq deleted the gh-3166-iproto-keys branch April 13, 2023 15:00
andreyaksenov pushed a commit that referenced this pull request May 23, 2023
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes.
* Renamed CLUSTER_UUID key to REPLICASET_UUID.
* Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description.
* Updated IPROTO_TERM key, updated heartbeats' description and byte codes.

Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299
andreyaksenov pushed a commit that referenced this pull request May 24, 2023
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes.
* Renamed CLUSTER_UUID key to REPLICASET_UUID.
* Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description.
* Updated IPROTO_TERM key, updated heartbeats' description and byte codes.

Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants