-
Notifications
You must be signed in to change notification settings - Fork 43
iproto: add new keys to Binary protocol page #3433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
05cfa1c
to
316ecfb
Compare
7ee889a
to
2d3ff19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
Looks good generally, please find a couple of comments below.
2d3ff19
to
511e4d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, found one broken link and added several minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes. * Renamed CLUSTER_UUID key to REPLICASET_UUID. * Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description. * Updated IPROTO_TERM key, updated heartbeats' description and byte codes. Resolves #3166 Resolves #3294 Resolves #3193 Resolves #3299
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes. * Renamed CLUSTER_UUID key to REPLICASET_UUID. * Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description. * Updated IPROTO_TERM key, updated heartbeats' description and byte codes. Resolves #3166 Resolves #3294 Resolves #3193 Resolves #3299
Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299
Updated vclock keys description
Updated description and svg for heartbeat messages (added IPROTO_VCLOCK_SYNC and IPROTO_TERM)
Updated IPROTO_BALLOT description