Skip to content

iproto: new key - IPROTO_VCLOCK_SYNC #3166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #3373
TarantoolBot opened this issue Sep 28, 2022 · 0 comments · Fixed by #3433
Closed
Tracked by #3373

iproto: new key - IPROTO_VCLOCK_SYNC #3166

TarantoolBot opened this issue Sep 28, 2022 · 0 comments · Fixed by #3433
Assignees
@xuniq
Labels
2.11 2.11 release and the associated technical debt feature A new functionality iproto Related to the iproto protocol reference [location] Tarantool manual, Reference part

Comments

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Sep 28, 2022 •
edited by xuniq
Loading

Product: Tarantool
Since: 2.11
Root document: https://www.tarantool.io/en/doc/latest/dev_guide/internals/box_protocol/
https://www.tarantool.io/en/doc/latest/dev_guide/internals/box_protocol/#heartbeats
SME: @ sergepetrenko
Estimation: 2sp

Details

Binary protocol receives a new key:
IPROTO_VCLOCK_SYNC = 0x5a
This key holds a MP_UINT value and is used only by replication
heartbeats. A master sends the monotonically growing vclock sync together
with some of its heartbeats, and replica replies with the greatest vclock
sync it has seen yet in its ACKs.
Requested by @sergepetrenko in tarantool/tarantool@e00f9da.
@xuniq xuniq added reference [location] Tarantool manual, Reference part feature A new functionality 1sp iproto Related to the iproto protocol labels Sep 29, 2022
@xuniq xuniq added this to the Estimate [@xuniq] milestone Sep 29, 2022
@xuniq xuniq added 2.11 2.11 release and the associated technical debt 2sp and removed 1sp labels Oct 12, 2022
@xuniq xuniq removed this from the Estimate [@xuniq] milestone Oct 13, 2022
@xuniq xuniq removed the 2sp label Oct 13, 2022
This was referenced Apr 4, 2023
Closed
Closed
Merged
@xuniq xuniq self-assigned this Apr 7, 2023
xuniq added a commit that referenced this issue Apr 13, 2023
@xuniq
iproto: add new keys to Binary protocol section (#3433)
8607c8a 
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes.
* Renamed CLUSTER_UUID key to REPLICASET_UUID.
* Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description.
* Updated IPROTO_TERM key, updated heartbeats' description and byte codes.

Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299
@xuniq xuniq closed this as completed Apr 13, 2023
@xuniq xuniq changed the title Binary protocol: new key - IPROTO_VCLOCK_SYNC iproto: new key - IPROTO_VCLOCK_SYNC Apr 28, 2023
andreyaksenov pushed a commit that referenced this issue May 23, 2023
@xuniq @andreyaksenov
iproto: add new keys to Binary protocol section (#3433)
d7dd6a2 
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes.
* Renamed CLUSTER_UUID key to REPLICASET_UUID.
* Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description.
* Updated IPROTO_TERM key, updated heartbeats' description and byte codes.

Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299
andreyaksenov pushed a commit that referenced this issue May 24, 2023
@xuniq @andreyaksenov
iproto: add new keys to Binary protocol section (#3433)
66710ac 
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes.
* Renamed CLUSTER_UUID key to REPLICASET_UUID.
* Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description.
* Updated IPROTO_TERM key, updated heartbeats' description and byte codes.

Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuniq xuniq

Labels
2.11 2.11 release and the associated technical debt feature A new functionality iproto Related to the iproto protocol reference [location] Tarantool manual, Reference part
Projects
None yet
Milestone
No milestone
2 participants
@TarantoolBot @xuniq