Skip to content

iproto: rename IPROTO_CLUSTER_UUID to IPROTO_REPLICASET_UUID #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #3373
TarantoolBot opened this issue Jan 19, 2023 · 0 comments · Fixed by #3433
Closed
Tracked by #3373

iproto: rename IPROTO_CLUSTER_UUID to IPROTO_REPLICASET_UUID #3299

TarantoolBot opened this issue Jan 19, 2023 · 0 comments · Fixed by #3433
Assignees
@xuniq
Labels
2.11 2.11 release and the associated technical debt behavior change [nature] Сhange in existing behavior dev_guide iproto Related to the iproto protocol

Comments

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Jan 19, 2023 •
edited by xuniq
Loading

Product: Tarantool
Since: 2.11
Audience/target: dev
Root document: https://www.tarantool.io/en/doc/latest/dev_guide/internals/iproto/keys/#general-replication
SME: @ Gerold103

Details

This is a name for one of the IProto keys. The key value doesn't
change and the protocol is still backward compatible. But better
rename it to IPROTO_REPLICASET_UUID, because in future
IPROTO_CLUSTER_UUID will most likely mean a different thing.
Requested by @Gerold103 in tarantool/tarantool@a24714c.
@veod32 veod32 added iproto Related to the iproto protocol behavior change [nature] Сhange in existing behavior labels Jan 20, 2023
@veod32 veod32 added the 2.11 2.11 release and the associated technical debt label Mar 6, 2023
@veod32 veod32 unassigned xuniq Apr 3, 2023
@xuniq xuniq mentioned this issue Apr 4, 2023
Closed
7 tasks
@xuniq xuniq self-assigned this Apr 7, 2023
@xuniq xuniq mentioned this issue Apr 10, 2023
Merged
@xuniq xuniq linked a pull request Apr 10, 2023 that will close this issue
iproto: add new keys to Binary protocol page #3433
Merged
xuniq added a commit that referenced this issue Apr 13, 2023
@xuniq
iproto: add new keys to Binary protocol section (#3433)
8607c8a 
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes.
* Renamed CLUSTER_UUID key to REPLICASET_UUID.
* Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description.
* Updated IPROTO_TERM key, updated heartbeats' description and byte codes.

Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299
@xuniq xuniq closed this as completed Apr 13, 2023
@xuniq xuniq changed the title Rename IPROTO_CLUSTER_UUID to IPROTO_REPLICASET_UUID iproto: rename IPROTO_CLUSTER_UUID to IPROTO_REPLICASET_UUID Apr 28, 2023
andreyaksenov pushed a commit that referenced this issue May 23, 2023
@xuniq @andreyaksenov
iproto: add new keys to Binary protocol section (#3433)
d7dd6a2 
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes.
* Renamed CLUSTER_UUID key to REPLICASET_UUID.
* Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description.
* Updated IPROTO_TERM key, updated heartbeats' description and byte codes.

Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299
andreyaksenov pushed a commit that referenced this issue May 24, 2023
@xuniq @andreyaksenov
iproto: add new keys to Binary protocol section (#3433)
66710ac 
* Added IPROTO_VCLOCK_SYNC key. Updated vclock keys description. Updated heartbeats' description and byte codes.
* Renamed CLUSTER_UUID key to REPLICASET_UUID.
* Added IPROTO_BALLOT_BOOTSTRAP_LEADER_UUID and IPROTO_BALLOT_REGISTERED_REPLICA_UUIDS keys. Updated IPROTO_BALLOT description.
* Updated IPROTO_TERM key, updated heartbeats' description and byte codes.

Resolves #3166
Resolves #3294
Resolves #3193
Resolves #3299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuniq xuniq

Labels
2.11 2.11 release and the associated technical debt behavior change [nature] Сhange in existing behavior dev_guide iproto Related to the iproto protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iproto: add new keys to Binary protocol page tarantool/doc
3 participants
@TarantoolBot @veod32 @xuniq