Touch a crate whenever its versions are changed #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, if uploading a new version of a crate didn't otherwise change the metadata (description, etc), the crate's updated_at record wouldn't be changed. The migration specifically checks if `updated_at` changed on the versions to make sure the touch doesn't happen if `downloads` was bumped. I wanted to avoid duplicating that here, so instead this will only happen if the row is new, or as a result of the trigger bumping updated_at on the version. I have specifically not included a query to correct existing data, as it's an irreversable operation. We should manually run a query like `UPDATE crates SET updated_at = MAX(crates.updated_at, SELECT(MAX(versions.updated_at) FROM versions WHERE versions.crate_id = crates.id))` if we want to correct existing data. Fixes rust-lang#908.
sgrif
force-pushed
the
sg-touch-crate-on-version-change
branch
from
10f0ede to
250c5f2
Compare
carols10cents
approved these changes
Aug 17, 2017
|
I wanted to deploy the readme change by itself, so since that's out now: bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Aug 20, 2017
931: Touch a crate whenever its versions are changed r=carols10cents Prior to this commit, if uploading a new version of a crate didn't otherwise change the metadata (description, etc), the crate's updated_at record wouldn't be changed. The migration specifically checks if `updated_at` changed on the versions to make sure the touch doesn't happen if `downloads` was bumped. I wanted to avoid duplicating that here, so instead this will only happen if the row is new, or as a result of the trigger bumping updated_at on the version. I have specifically not included a query to correct existing data, as it's an irreversable operation. We should manually run a query like `UPDATE crates SET updated_at = MAX(crates.updated_at, SELECT(MAX(versions.updated_at) FROM versions WHERE versions.crate_id = crates.id))` if we want to correct existing data. Fixes #908. Close #925. 936: Add more documentation r=carols10cents As part of the effort to better document crates.io, I added more documentation comments to the `krate::index` and `krate::new` functions as well as to some associated functions. Also added some comments in some functions and to document. Thanks for providing the background on these functions @carols10cents :). I'd like to doc comment the git::yank function as well before this gets merged. 969: crate.scss: When rendering code in README, don't show scrollbar unless necessary r=carols10cents The current `overflow-x: scroll` shows a scrollbar all the time, even for code blocks that don't need them. Switch to `overflow-x: auto`, to only show the scrollbar when needed. 979: CSS: Restrict readme image width r=carols10cents Fixes #971
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if uploading a new version of a crate didn't
otherwise change the metadata (description, etc), the crate's updated_at
record wouldn't be changed.
The migration specifically checks if
updated_atchanged on theversions to make sure the touch doesn't happen if
downloadswasbumped. I wanted to avoid duplicating that here, so instead this will
only happen if the row is new, or as a result of the trigger bumping
updated_at on the version.
I have specifically not included a query to correct existing data, as
it's an irreversable operation. We should manually run a query like
UPDATE crates SET updated_at = MAX(crates.updated_at, SELECT(MAX(versions.updated_at) FROM versions WHERE versions.crate_id = crates.id))if we want to correct existing data.Fixes #908.
Close #925.