Skip to content

README images overflow into area's they're not supposed to. #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrmuizel opened this issue Aug 19, 2017 · 2 comments
Closed

README images overflow into area's they're not supposed to. #971

jrmuizel opened this issue Aug 19, 2017 · 2 comments
Labels
C-bug 🐞 Category: unintended, undesired behavior

Comments

@jrmuizel
Copy link

See https://crates.io/crates/goblin.

Adding "max-width: 100%" solves the problem.

@MaikKlein
Copy link

Same here https://crates.io/crates/ash

@carols10cents carols10cents added the C-bug 🐞 Category: unintended, undesired behavior label Aug 19, 2017
@carols10cents
Copy link
Member

LOL the goblin image!!! 😂😂😂

bors-voyager bot added a commit that referenced this issue Aug 20, 2017
931: Touch a crate whenever its versions are changed r=carols10cents

Prior to this commit, if uploading a new version of a crate didn't
otherwise change the metadata (description, etc), the crate's updated_at
record wouldn't be changed.

The migration specifically checks if `updated_at` changed on the
versions to make sure the touch doesn't happen if `downloads` was
bumped. I wanted to avoid duplicating that here, so instead this will
only happen if the row is new, or as a result of the trigger bumping
updated_at on the version.

I have specifically not included a query to correct existing data, as
it's an irreversable operation. We should manually run a query like
`UPDATE crates SET updated_at = MAX(crates.updated_at,
SELECT(MAX(versions.updated_at) FROM versions WHERE versions.crate_id =
crates.id))` if we want to correct existing data.

Fixes #908.
Close #925.

936: Add more documentation r=carols10cents

As part of the effort to better document crates.io, I added more documentation comments to the `krate::index` and `krate::new` functions as well as to some associated functions. Also added some comments in some functions and to document. Thanks for providing the background on these functions @carols10cents :).

I'd like to doc comment the git::yank function as well before this gets merged.

969: crate.scss: When rendering code in README, don't show scrollbar unless necessary r=carols10cents

The current `overflow-x: scroll` shows a scrollbar all the time, even
for code blocks that don't need them. Switch to `overflow-x: auto`, to
only show the scrollbar when needed.

979: CSS: Restrict readme image width r=carols10cents

Fixes #971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Development

No branches or pull requests

3 participants