Skip to content

"Last updated" on a crate page isn't updating on new version publish #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carols10cents opened this issue Jul 23, 2017 · 1 comment
Closed

"Last updated" on a crate page isn't updating on new version publish #908

carols10cents opened this issue Jul 23, 2017 · 1 comment
Labels
A-backend ⚙️ A-publish C-bug 🐞 Category: unintended, undesired behavior E-help-wanted

Comments

@carols10cents
Copy link
Member

ex: https://crates.io/crates/conduit-cookie, it says last updated 4 months ago but 0.8.4 was published yesterday

screen_shot_2017-07-23_at_6_20_37_pm
@notriddle
Copy link
Contributor

I'd like to claim this issue.

notriddle added a commit to notriddle/crates.io that referenced this issue Aug 1, 2017
@notriddle
Always bump the updated_at on uploads
8ee69be 
Fixes rust-lang#908
@notriddle notriddle mentioned this issue Aug 1, 2017
Closed
notriddle added a commit to notriddle/crates.io that referenced this issue Aug 1, 2017
@notriddle
Always bump the updated_at on uploads
b8bd001 
Fixes rust-lang#908
sgrif added a commit to sgrif/crates.io that referenced this issue Aug 1, 2017
@sgrif
Touch a crate whenever its versions are changed
10f0ede 
Prior to this commit, if uploading a new version of a crate didn't
otherwise change the metadata (description, etc), the crate's updated_at
record wouldn't be changed.

The migration specifically checks if `updated_at` changed on the
versions to make sure the touch doesn't happen if `downloads` was
bumped. I wanted to avoid duplicating that here, so instead this will
only happen if the row is new, or as a result of the trigger bumping
updated_at on the version.

I have specifically not included a query to correct existing data, as
it's an irreversable operation. We should manually run a query like
`UPDATE crates SET updated_at = MAX(crates.updated_at,
SELECT(MAX(versions.updated_at) FROM versions WHERE versions.crate_id =
crates.id))` if we want to correct existing data.

Fixes rust-lang#908.
@sgrif sgrif mentioned this issue Aug 1, 2017
Merged
sgrif added a commit to sgrif/crates.io that referenced this issue Aug 1, 2017
@sgrif
Touch a crate whenever its versions are changed
250c5f2 
Prior to this commit, if uploading a new version of a crate didn't
otherwise change the metadata (description, etc), the crate's updated_at
record wouldn't be changed.

The migration specifically checks if `updated_at` changed on the
versions to make sure the touch doesn't happen if `downloads` was
bumped. I wanted to avoid duplicating that here, so instead this will
only happen if the row is new, or as a result of the trigger bumping
updated_at on the version.

I have specifically not included a query to correct existing data, as
it's an irreversable operation. We should manually run a query like
`UPDATE crates SET updated_at = MAX(crates.updated_at,
SELECT(MAX(versions.updated_at) FROM versions WHERE versions.crate_id =
crates.id))` if we want to correct existing data.

Fixes rust-lang#908.
@carols10cents carols10cents mentioned this issue Aug 11, 2017
Closed
bors-voyager bot added a commit that referenced this issue Aug 20, 2017
@bors-voyager
Merge #931 #936 #969 #979
1072531 
931: Touch a crate whenever its versions are changed r=carols10cents

Prior to this commit, if uploading a new version of a crate didn't
otherwise change the metadata (description, etc), the crate's updated_at
record wouldn't be changed.

The migration specifically checks if `updated_at` changed on the
versions to make sure the touch doesn't happen if `downloads` was
bumped. I wanted to avoid duplicating that here, so instead this will
only happen if the row is new, or as a result of the trigger bumping
updated_at on the version.

I have specifically not included a query to correct existing data, as
it's an irreversable operation. We should manually run a query like
`UPDATE crates SET updated_at = MAX(crates.updated_at,
SELECT(MAX(versions.updated_at) FROM versions WHERE versions.crate_id =
crates.id))` if we want to correct existing data.

Fixes #908.
Close #925.

936: Add more documentation r=carols10cents

As part of the effort to better document crates.io, I added more documentation comments to the `krate::index` and `krate::new` functions as well as to some associated functions. Also added some comments in some functions and to document. Thanks for providing the background on these functions @carols10cents :).

I'd like to doc comment the git::yank function as well before this gets merged.

969: crate.scss: When rendering code in README, don't show scrollbar unless necessary r=carols10cents

The current `overflow-x: scroll` shows a scrollbar all the time, even
for code blocks that don't need them. Switch to `overflow-x: auto`, to
only show the scrollbar when needed.

979: CSS: Restrict readme image width r=carols10cents

Fixes #971
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-backend ⚙️ A-publish C-bug 🐞 Category: unintended, undesired behavior E-help-wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carols10cents @notriddle