Skip to content

Crate version in search results doesn't match version on crate page #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
camelid opened this issue Aug 21, 2020 · 5 comments
Closed

Crate version in search results doesn't match version on crate page #2710

camelid opened this issue Aug 21, 2020 · 5 comments
Assignees
@camelid
Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior

Comments

@camelid
Copy link
Member

camelid commented Aug 21, 2020 •
edited by rustbot
Loading

See for example with clap:

Search Results

image

/crates/clap

image

The version on the search page is a beta, while the version on the crate page (/crates/clap) is the latest stable release.
@camelid
Copy link
Member Author

camelid commented Aug 21, 2020

@rustbot modify labels: A-versions C-bug

@rustbot rustbot added A-versions C-bug 🐞 Category: unintended, undesired behavior labels Aug 21, 2020
@JohnTitor JohnTitor mentioned this issue Aug 21, 2020
Closed
This was referenced Aug 21, 2020
Closed
Closed
@camelid
Copy link
Member Author

camelid commented Aug 21, 2020 •
edited
Loading

Another example:

Search Results

image

Crate Page

image

@camelid
Copy link
Member Author

camelid commented Sep 5, 2020

I'm interested in working on this.

@rustbot claim

@camelid camelid mentioned this issue Sep 5, 2020
Closed
@Turbo87 Turbo87 mentioned this issue Dec 3, 2020
Merged
bors added a commit that referenced this issue Dec 22, 2020
@bors
Auto merge of #3067 - Turbo87:top-version-tests, r=jtgeibel
365928d 
models/version: Add tests for `Version::top()` function

While this can be tested through API tests it's much more convenient to have a unit tests for this functionality.

This PR is in preparation for fixing #2710, by introducing a `max_stable_version` property on the `crate` resource.

r? `@jtgeibel`
@Turbo87 Turbo87 mentioned this issue Dec 23, 2020
Merged
@jyn514
Copy link
Member

jyn514 commented Dec 27, 2020

This is a duplicate of #654 I think.

@Turbo87
Copy link
Member

Turbo87 commented Dec 28, 2020

indeed, yeah. closing in favor of #654. thanks @jyn514 :)

@Turbo87 Turbo87 closed this as completed Dec 28, 2020
bors added a commit that referenced this issue Jan 5, 2021
@bors
Auto merge of #3113 - Turbo87:top-version-cleanup, r=jtgeibel
c2d1818 
Clean up `TopVersions` code

This PR cleans up the code that figures out the `highest` and `newest` versions of a crate in several ways. I hope that the commit list gives enough context on the individual changes.

Primarily, this decouples the code from the `Version` struct, and it moves the `0.0.0` defaulting to the `encodable()` method of the `Krate` model, instead of performing that in the low-level code directly.

Like #3067, this PR is also in preparation for resolving #2710.

r? `@jtgeibel`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camelid camelid

Labels
A-frontend 🐹 C-bug 🐞 Category: unintended, undesired behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mismatch in crate versions between pages camelid/crates.io
5 participants
@Turbo87 @jyn514 @JohnTitor @camelid @rustbot