Clean up TopVersions code
#3113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
top-version-cleanup
branch
5 times, most recently
from
884c3bb to
ea476d3
Compare
Turbo87
force-pushed
the
top-version-cleanup
branch
2 times, most recently
from
75bb6f7 to
004aa95
Compare
Turbo87
force-pushed
the
top-version-cleanup
branch
from
004aa95 to
7a71e00
Compare
|
Looks awesome! @bors r+ |
|
📌 Commit 7a71e00 has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the code that figures out the
highestandnewestversions of a crate in several ways. I hope that the commit list gives enough context on the individual changes.Primarily, this decouples the code from the
Versionstruct, and it moves the0.0.0defaulting to theencodable()method of theKratemodel, instead of performing that in the low-level code directly.Like #3067, this PR is also in preparation for resolving #2710.
r? @jtgeibel