feat: add metadata support for Metrics #1323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 11, 2022
Right now, the only metadata that's provided is the group/version/kind information associated with the resource being processed. Fixes #1322.
csviri
requested changes
Jul 13, 2022
| @@ -22,4 +25,21 @@ default <T> Optional<T> getSecondaryResource(Class<T> expectedType) { | |||
| ControllerConfiguration<P> getControllerConfiguration(); | |||
|
|
|||
| ManagedDependentResourceContext managedDependentResourceContext(); | |||
|
|
|||
| ResourceID currentlyReconciledResourceID(); | |||
There was a problem hiding this comment.
Why are we exposing this to the user? This is not usable at all for him. Could be very confusing? Is this this for metrics?
|
|
||
| ResourceID currentlyReconciledResourceID(); | ||
|
|
||
| Map<String, Object> metadata(); |
There was a problem hiding this comment.
Same here why is this in the context and not hidden from the user?
|
Kudos, SonarCloud Quality Gate passed! |
csviri
added a commit
that referenced
this pull request
Jul 13, 2022
Right now, the only metadata that's provided is the group/version/kind information associated with the resource being processed. Fixes #1322. Fixes #1324. Co-authored-by: csviri <[email protected]>
csviri
added a commit
that referenced
this pull request
Jul 13, 2022
Right now, the only metadata that's provided is the group/version/kind information associated with the resource being processed. Fixes #1322. Fixes #1324. Co-authored-by: csviri <[email protected]>
csviri
added a commit
that referenced
this pull request
Jul 14, 2022
Right now, the only metadata that's provided is the group/version/kind information associated with the resource being processed. Fixes #1322. Fixes #1324. Co-authored-by: csviri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.
Fixes #1322 #1324.
Builds on top of #1319.