Skip to content

Metrics#timeControllerExecution should include resource identifier #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gyfora opened this issue Jul 10, 2022 · 0 comments · Fixed by #1323
Closed

Metrics#timeControllerExecution should include resource identifier #1324

gyfora opened this issue Jul 10, 2022 · 0 comments · Fixed by #1323
Milestone
3.1

Comments

@gyfora
Copy link

gyfora commented Jul 10, 2022

I feel that it would make sense to add the ResourceId to either the ControllerExecution interface or the timeControllerExecution method as parameter.

This way we could associate time measurements with reasources/namespaces etc. Currently the best we can do is to associate them to a resource type via the controller name.
metacosm added a commit that referenced this issue Jul 11, 2022
@metacosm
feat: add resource metadata to Context and ControllerExecution
dba05d8 
Fixes #1324.
@metacosm metacosm mentioned this issue Jul 11, 2022
Merged
@metacosm metacosm linked a pull request Jul 11, 2022 that will close this issue
feat: add metadata support for Metrics #1323
Merged
metacosm added a commit that referenced this issue Jul 11, 2022
@metacosm
feat: add resource metadata to Context and ControllerExecution
29310b9 
Fixes #1324.
csviri pushed a commit that referenced this issue Jul 13, 2022
@metacosm @csviri
feat: add resource metadata to Context and ControllerExecution
530486c 
Fixes #1324.
metacosm added a commit that referenced this issue Jul 13, 2022
@metacosm @csviri
feat: add metadata support for Metrics (#1323)
4018456 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
Fixes #1324.

Co-authored-by: csviri <[email protected]>
csviri added a commit that referenced this issue Jul 13, 2022
@metacosm @csviri
feat: add metadata support for Metrics (#1323)
efe35d9 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
Fixes #1324.

Co-authored-by: csviri <[email protected]>
csviri added a commit that referenced this issue Jul 13, 2022
@metacosm @csviri
feat: add metadata support for Metrics (#1323)
558c1c6 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
Fixes #1324.

Co-authored-by: csviri <[email protected]>
@csviri csviri added this to the 3.1 milestone Jul 13, 2022
@csviri csviri closed this as completed Jul 13, 2022
csviri added a commit that referenced this issue Jul 14, 2022
@metacosm @csviri
feat: add metadata support for Metrics (#1323)
e723525 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
Fixes #1324.

Co-authored-by: csviri <[email protected]>
@sorend sorend mentioned this issue Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

feat: add metadata support for Metrics operator-framework/java-operator-sdk
2 participants
@csviri @gyfora