Skip to content

Add resource type/kind to Metrics method to distinguish between identically named resources of different types #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
metacosm opened this issue Jul 8, 2022 · 1 comment · Fixed by #1323
Closed

Add resource type/kind to Metrics method to distinguish between identically named resources of different types #1322

metacosm opened this issue Jul 8, 2022 · 1 comment · Fixed by #1323
Assignees
@metacosm
Milestone
3.1

Comments

@metacosm
Copy link
Collaborator

metacosm commented Jul 8, 2022

No description provided.

@metacosm metacosm self-assigned this Jul 8, 2022
@csviri csviri added this to the 3.2 milestone Jul 8, 2022
metacosm added a commit that referenced this issue Jul 8, 2022
@metacosm
feat: add metadata support for Metrics
8b099eb 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
@metacosm metacosm mentioned this issue Jul 8, 2022
Merged
@gyfora
Copy link

gyfora commented Jul 10, 2022

Thank you for creating this issue :)

@metacosm metacosm linked a pull request Jul 11, 2022 that will close this issue
feat: add metadata support for Metrics #1323
Merged
metacosm added a commit that referenced this issue Jul 11, 2022
@metacosm
feat: add metadata support for Metrics
21532e1 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
csviri pushed a commit that referenced this issue Jul 13, 2022
@metacosm @csviri
feat: add metadata support for Metrics
2894e53 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
metacosm added a commit that referenced this issue Jul 13, 2022
@metacosm @csviri
feat: add metadata support for Metrics (#1323)
4018456 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
Fixes #1324.

Co-authored-by: csviri <[email protected]>
csviri added a commit that referenced this issue Jul 13, 2022
@metacosm @csviri
feat: add metadata support for Metrics (#1323)
efe35d9 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
Fixes #1324.

Co-authored-by: csviri <[email protected]>
csviri added a commit that referenced this issue Jul 13, 2022
@metacosm @csviri
feat: add metadata support for Metrics (#1323)
558c1c6 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
Fixes #1324.

Co-authored-by: csviri <[email protected]>
@csviri csviri modified the milestones: 3.2, 3.1 Jul 13, 2022
@csviri csviri closed this as completed Jul 13, 2022
csviri added a commit that referenced this issue Jul 14, 2022
@metacosm @csviri
feat: add metadata support for Metrics (#1323)
e723525 
Right now, the only metadata that's provided is the group/version/kind
information associated with the resource being processed.

Fixes #1322.
Fixes #1324.

Co-authored-by: csviri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

feat: add metadata support for Metrics operator-framework/java-operator-sdk
3 participants
@metacosm @csviri @gyfora