feat: workflow Integration with API (dependent annotations, context) #1257

csviri · 2022-06-01T10:48:07Z

No description provided.

metacosm · 2022-06-08T12:17:45Z

...e/src/test/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProviderTest.java

@@ -55,7 +55,8 @@ void resetShouldResetAllState() {
    shouldBePossibleToOverrideConfigOnce();

    ConfigurationServiceProvider.reset();
-    assertEquals(ConfigurationServiceProvider.DEFAULT, ConfigurationServiceProvider.getDefault());
+    assertNotEquals(ConfigurationServiceProvider.getDefault(),


This is wrong. After calling reset, we should get the default ConfigurationService.

Will comment this in the code, what I wanted to achieve is that reseting it does provide a new instance of the new config, see the explanation below.

metacosm · 2022-06-08T12:18:31Z

...e/src/test/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProviderTest.java

@@ -55,7 +55,8 @@ void resetShouldResetAllState() {
    shouldBePossibleToOverrideConfigOnce();

    ConfigurationServiceProvider.reset();
-    assertEquals(ConfigurationServiceProvider.DEFAULT, ConfigurationServiceProvider.getDefault());
+    assertNotEquals(ConfigurationServiceProvider.getDefault(),
+        ConfigurationServiceProvider.createDefault());


Also, createDefault shouldn't be accessible from outside of the ConfigurationServiceProvider class, imo.

A set it package private so it is testable.

metacosm · 2022-06-08T12:19:36Z

...-core/src/main/java/io/javaoperatorsdk/operator/api/config/ConfigurationServiceProvider.java

  private static ConfigurationService instance;
-  private static ConfigurationService defaultConfigurationService = DEFAULT;
+  private static ConfigurationService defaultConfigurationService = createDefault();


What's the point of that change? See also comments on the associated test class…

Yes, this solves an issue with the integration tests, basically since it is singleton, it needs to be reseted after the integration tests. But if the DEFAULT is not created again (with this method in reset) , the configurations are for dependents stay in there and causes trouble. This is just for tests.

see: https://github.com/java-operator-sdk/java-operator-sdk/blob/0b7dc97de05df069e2db87384a9d1f67b3e79724/operator-framework-junit5/src/main/java/io/javaoperatorsdk/operator/junit/AbstractOperatorExtension.java#L165-L165

🤔 I guess the current reset implementation is indeed wrong…

metacosm · 2022-06-08T13:34:38Z

...vaoperatorsdk/operator/api/reconciler/dependent/managed/ManagedDependentResourceContext.java

- */
-@SuppressWarnings("rawtypes")
-public class ManagedDependentResourceContext {
+public interface ManagedDependentResourceContext {


What's the point of extracting an interface here when there's only one implementation?

I extracted it for the same reason, since this is a user facing interface, so the setters should not be accessible. Thus is denotes the intention as much as possible.

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

...torsdk/operator/api/reconciler/dependent/managed/DefaultManagedDependentResourceContext.java

...peratorsdk/operator/processing/dependent/kubernetes/CRUDNoGCKubernetesDependentResource.java

...java/io/javaoperatorsdk/operator/processing/dependent/workflow/builder/DependentBuilder.java

metacosm · 2022-06-08T13:47:17Z

...in/java/io/javaoperatorsdk/operator/processing/dependent/workflow/DependentResourceNode.java

-        + dependsOn.stream().map(d -> d.dependentResource.toString())
-            .collect(Collectors.joining(", ", "->[", "]"))
-        + '}';
+    return "DependentResourceNode{" +


This version of toString isn't really useful…

Why, basically a reverted this, since you can see easily the parents and the whole structure just by looking on workflow definition. So was debugging this, and searching for issues during the development on lot's of occasions, and this was always sufficient to find the problem.

…va-operator-sdk into annotation-workflow

sonarqubecloud · 2022-06-09T08:02:53Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
23 Code Smells

63.0% Coverage
0.5% Duplication

…1257)

csviri self-assigned this Jun 1, 2022

csviri changed the title ~~Feat: workflow Integration with API (dependent annotations, context)~~ feat: workflow Integration with API (dependent annotations, context) Jun 1, 2022

metacosm self-requested a review June 1, 2022 18:11

csviri force-pushed the next branch from 2a41476 to 83ed3c2 Compare June 2, 2022 07:46

csviri force-pushed the annotation-workflow branch from e8a1c2f to 828dc09 Compare June 2, 2022 12:07

csviri force-pushed the next branch from 83ed3c2 to 3453ec0 Compare June 2, 2022 12:09

csviri force-pushed the annotation-workflow branch from 828dc09 to e1c617f Compare June 2, 2022 12:13

csviri marked this pull request as ready for review June 3, 2022 07:06

csviri marked this pull request as draft June 3, 2022 14:53

csviri marked this pull request as ready for review June 6, 2022 14:34

csviri linked an issue Jun 6, 2022 that may be closed by this pull request

Define workflows with dependent resource annotations #1241

Closed

csviri mentioned this pull request Jun 6, 2022

DependentResource and Workflow Design Details Questions #1263

Closed

2 tasks

csviri linked an issue Jun 6, 2022 that may be closed by this pull request

DependentResource and Workflow Design Details Questions #1263

Closed

2 tasks

csviri force-pushed the next branch from 3453ec0 to 3026876 Compare June 7, 2022 08:28

csviri added 16 commits June 7, 2022 10:33

feat: annotation config for workflow

2d3c111

wip

7c40e1b

impl skeleton

5c62702

wip

e344e77

untit test for workflow utils

7ca2a9f

workflow api integration

6a91a5d

fixes

6916bb4

it fix

b45a0e3

IT fix

6af09ff

renaming

88d81d0

refactors, tests

9fb2ffb

wip

6e6d47a

additional unit tests

8e08769

format

0e3693b

updated samples

01b6ffd

IT wip

8d26095

metacosm added 4 commits June 8, 2022 21:25

refactor: no need for mock, makes things faster & easier to debug

e3771f2

chore(tests): add more tests

b3dbfbd

refactor: simplify and make orderAndDetectCycles more readable

ff71f3b

refactor: avoid creating a ManagedWorkflow instance when not needed

18bdddf

metacosm requested changes Jun 8, 2022

View reviewed changes

metacosm and others added 7 commits June 8, 2022 22:52

fix: rename test to reflect use case

4b01cb8

chore: format

ad988b1

ˆ

3f12362

fix: possible NPE

f8d3c16

moved javadoc

9156441

Merge branch 'annotation-workflow' of github.com:java-operator-sdk/ja…

0b7dc97

…va-operator-sdk into annotation-workflow

comment in test

e951058

metacosm approved these changes Jun 9, 2022

View reviewed changes

csviri merged commit b439c1c into next Jun 9, 2022

csviri deleted the annotation-workflow branch June 9, 2022 13:14

csviri added a commit that referenced this pull request Jun 9, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

ad1742d

…1257)

csviri added a commit that referenced this pull request Jun 17, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

0400ba3

…1257)

csviri added a commit that referenced this pull request Jun 27, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

ca4eafd

…1257)

csviri added a commit that referenced this pull request Jun 27, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

43d846f

…1257)

csviri added a commit that referenced this pull request Jun 28, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

cb0fab5

…1257)

csviri added a commit that referenced this pull request Jun 28, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

2bd8b47

…1257)

metacosm mentioned this pull request Jul 1, 2022

more event filters #1309

Closed

csviri added a commit that referenced this pull request Jul 4, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

039bd86

…1257)

csviri added a commit that referenced this pull request Jul 4, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

4065802

…1257)

csviri added a commit that referenced this pull request Jul 11, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

09cedd8

…1257)

csviri added a commit that referenced this pull request Jul 13, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

b62f008

…1257)

csviri added a commit that referenced this pull request Jul 13, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

e34ec59

…1257)

csviri added a commit that referenced this pull request Jul 13, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

711152d

…1257)

csviri added a commit that referenced this pull request Jul 14, 2022

feat: workflow Integration with API (dependent annotations, context) (#…

b5dfe18

…1257)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: workflow Integration with API (dependent annotations, context) #1257

feat: workflow Integration with API (dependent annotations, context) #1257

csviri commented Jun 1, 2022

metacosm Jun 8, 2022

csviri Jun 9, 2022

metacosm Jun 8, 2022

csviri Jun 9, 2022

metacosm Jun 8, 2022

csviri Jun 9, 2022

metacosm Jun 9, 2022

metacosm Jun 8, 2022

csviri Jun 9, 2022

metacosm Jun 8, 2022

csviri Jun 9, 2022

sonarqubecloud bot commented Jun 9, 2022

feat: workflow Integration with API (dependent annotations, context) #1257

feat: workflow Integration with API (dependent annotations, context) #1257

Conversation

csviri commented Jun 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jun 9, 2022