more event filters #1309
Closed
more event filters #1309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
metacosm
commented
Jul 1, 2022
•
metacosm
commented
- refactor: share filter handling (wip)
…ner reference can be added (#1197)
Note: I don't think that the unit tests are correct, see todos. The filters should come from the configuration and we shouldn't override them like is currently done but got through the ConfigurationOverrider mechanism.
|
Kudos, SonarCloud Quality Gate passed! |
csviri
requested changes
Jul 4, 2022
|
|
||
| public void setOnDeleteFilter(BiPredicate<R, Boolean> onDeleteFilter) { | ||
| this.onDeleteFilter = onDeleteFilter; | ||
| public void initFilters(Predicate<R> onAddFilter, BiPredicate<R, R> onUpdateFilter, |
There was a problem hiding this comment.
This is not a very nice API, with all the null values required.
| propagateEvent(resource); | ||
| } | ||
| } | ||
|
|
||
| private synchronized void onAddOrUpdate(Operation operation, R newObject, R oldObject, | ||
| private synchronized void onAddOrUpdate(ResourceAction operation, R newObject, R oldObject, |
There was a problem hiding this comment.
The separate Operation was intentional to exclude delete. I don't think this needs to be changed, it is more explicit that way.
There was a problem hiding this comment.
That is something completely different from filters.
csviri
reviewed
Jul 4, 2022
| @@ -25,11 +25,7 @@ default Optional<R> getSecondaryResource(P primary) { | |||
|
|
|||
| Set<R> getSecondaryResources(P primary); | |||
|
|
|||
| void setOnAddFilter(Predicate<R> onAddFilter); | |||
There was a problem hiding this comment.
Why is not initFilters better than having setters?
csviri
reviewed
Jul 4, 2022
|
|
||
| public void setOnDeleteFilter(BiPredicate<R, Boolean> onDeleteFilter) { | ||
| this.onDeleteFilter = onDeleteFilter; | ||
| public void initFilters(Predicate<R> onAddFilter, BiPredicate<R, R> onUpdateFilter, |
There was a problem hiding this comment.
When this is intended to be called? Since it should be afterinitEventSource, but that is called after the event source initialized. Can we add an integration test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.