Skip to content

DependentResource and Workflow Design Details Questions #1263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
Tracked by #1097
csviri opened this issue Jun 2, 2022 · 3 comments · Fixed by #1257
Closed
2 tasks done
Tracked by #1097

DependentResource and Workflow Design Details Questions #1263

csviri opened this issue Jun 2, 2022 · 3 comments · Fixed by #1257
Assignees
Labels
dependent-resources-epic needs-discussion Issue needs to be discussed more before working on it workflows
Milestone

Comments

@csviri
Copy link
Collaborator

csviri commented Jun 2, 2022

This issue is a summary some design questions related to dependent resources and workflows.

  • Currently if a dependent resource is ready (ReadyCondition) in workflows (so is in a target state) or if is delete process successfully finished (DeletePostCondition) - this can be async - is handled by Conditions. However it might be more convenient especially using it from standalone mode to put this information to ReconcileResult and also provide DeleteResult where the result of those predicates could be added. Also might be a better / more efficient place to check it in the reconcile.
  • Should we make in all condition names explicit if it is a post or precondition. Ready is a post, Reconcile is a pre-condition. The delete condition already has post in its name. See original design:
    Depends On and Conditions to describe workflows Dependent Resources #850 (only applies to reconcile condition if we decide to change the point above)
@csviri csviri added needs-discussion Issue needs to be discussed more before working on it dependent-resources-epic workflows labels Jun 2, 2022
@csviri csviri self-assigned this Jun 2, 2022
@csviri csviri added this to the 3.1 milestone Jun 2, 2022
@csviri csviri changed the title Some DependentResource and Workflow Design Details DependentResource and Workflow Design Details Questions Jun 2, 2022
@csviri
Copy link
Collaborator Author

csviri commented Jun 6, 2022

Made the condition names more explicit (pre and post condition) in the following PR:
#1257

@csviri
Copy link
Collaborator Author

csviri commented Jun 6, 2022

After giving more thoughts and implementing samples (Integration tests). Having the postconditions explicit makes more sense. It is good for reusability, also for decoupling the condition related logic. For now I would say we could keep it separated and maybe change if we have some related feedback.

@csviri
Copy link
Collaborator Author

csviri commented Jun 6, 2022

Will close this issue for now, and reopen in case.

@csviri csviri closed this as completed Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent-resources-epic needs-discussion Issue needs to be discussed more before working on it workflows
Projects
None yet
1 participant