Mixer config api swagger with a link to doc #66

mandarjog · 2017-03-30T17:36:00Z

This adds mixer config API spec with foremost focus on Alpha.

https://docs.google.com/document/d/17Ww_wS72UvGa15WipUibyLetlLNjK3hnqi-DfhkpoMg/edit#heading=h.x8zcnr9affp0

geeknoid · 2017-03-30T17:45:45Z

mixer/v1/config_api_swagger.yaml

+# for details
+info:
+  version: "0.1.0"
+  title: Istio Mixer Config API


Config -> Configuration

geeknoid · 2017-03-30T17:46:13Z

mixer/v1/config_api_swagger.yaml

+info:
+  version: "0.1.0"
+  title: Istio Mixer Config API
+  description: Mixer Configuration API allows users to configure all facets of a mixer deployment.


The mixer (mixer is a common noun, not a proper noun)

geeknoid · 2017-03-30T17:46:54Z

mixer/v1/config_api_swagger.yaml

+  version: "0.1.0"
+  title: Istio Mixer Config API
+  description: Mixer Configuration API allows users to configure all facets of a mixer deployment.
+    Mixer configuration is organized in `scope -> subject -> rule` hierarchy.


The mixer's configuration is organized in a ...

geeknoid · 2017-03-30T17:47:12Z

mixer/v1/config_api_swagger.yaml

+  title: Istio Mixer Config API
+  description: Mixer Configuration API allows users to configure all facets of a mixer deployment.
+    Mixer configuration is organized in `scope -> subject -> rule` hierarchy.
+    __scope__ and __subject__ are analogous to `manager > employee` relationship. A __manager__(`scope`)  may configure any direct or indirect __reports__ (`subject`) including self.


analogous to a

geeknoid · 2017-03-30T17:48:25Z

mixer/v1/config_api_swagger.yaml

+      `global`, `namespace:ns1.cluster.local` are examples of scopes. Rules contained in a scope can only affect that scope.
+
+      Scopes are hierarchical. 
+      Given a kubernetes style fully qualified service name `svc1.ns1.cluster.local`, 


Given a fully-qualified Kubernetes-style service name such as

geeknoid · 2017-03-30T18:56:45Z

mixer/v1/config_api_swagger.yaml

+      message:
+        type: string
+  aspectListMap:
+    description: map[aspectKind] aspectList


Probably want a non-Go description :-)

geeknoid · 2017-03-30T18:57:10Z

mixer/v1/config_api_swagger.yaml

+    description: map[aspectKind] aspectList
+    type: object
+  policy:
+    description: list of aspect AspectRule


List of rules

geeknoid · 2017-03-30T18:57:28Z

mixer/v1/config_api_swagger.yaml

+          $ref: '#/definitions/ruleInfo'
+  descriptor:
+    description: |
+      payload while creating and fetching descriptors. 


geeknoid · 2017-03-30T18:58:03Z

mixer/v1/config_api_swagger.yaml

+      See https://github.com/istio/api/tree/master/mixer/v1/config/descriptor for details.
+    type: object
+  adapter:
+    description: adapter definition


geeknoid · 2017-03-30T18:58:57Z

mixer/v1/config_api_swagger.yaml

+    properties:
+      kind:
+        description: |
+          optional array of kinds. It can be specified to restrict the `kinds` that the adapter provides. If kind is unspecified, it is left to the adapter  


Optional.

Allowing the operator to constrain the kinds of an adapter exposes seems like an anti-feature. At the very least, it's extremely esoteric and I would rather we remove this from the design.

Removed for Alpha.

Here is why it was there.
consider a GCP adapter that provides metrics, iam and logging aspects.
If I configure it as

name: default
impl: gcp
params: { }

This makes the same adapterconfig default for 3 aspects.
default-metrics, default-iam and default-logging
If I want to use prometheus as my default metrics provider, I can't do that now.
"Kind" restricts the named adapterconfig to the specified aspects.

mandarjog

Updated PTAL.

mandarjog · 2017-03-30T20:04:28Z

mixer/v1/config_api_swagger.yaml

+    get:
+      operationId: listScopes
+      description: |
+        Gets `scopes` available in the system.


it renders pre-formatted text in markdown.

mandarjog · 2017-03-30T20:04:50Z

mixer/v1/config_api_swagger.yaml

+# for details
+info:
+  version: "0.1.0"
+  title: Istio Mixer Config API


mandarjog · 2017-03-30T20:05:22Z

mixer/v1/config_api_swagger.yaml

+  title: Istio Mixer Config API
+  description: Mixer Configuration API allows users to configure all facets of a mixer deployment.
+    Mixer configuration is organized in `scope -> subject -> rule` hierarchy.
+    __scope__ and __subject__ are analogous to `manager > employee` relationship. A __manager__(`scope`)  may configure any direct or indirect __reports__ (`subject`) including self.


mandarjog · 2017-03-30T20:05:29Z

mixer/v1/config_api_swagger.yaml

+  version: "0.1.0"
+  title: Istio Mixer Config API
+  description: Mixer Configuration API allows users to configure all facets of a mixer deployment.
+    Mixer configuration is organized in `scope -> subject -> rule` hierarchy.


mandarjog · 2017-03-30T20:06:43Z

mixer/v1/config_api_swagger.yaml

+      `global`, `namespace:ns1.cluster.local` are examples of scopes. Rules contained in a scope can only affect that scope.
+
+      Scopes are hierarchical. 
+      Given a kubernetes style fully qualified service name `svc1.ns1.cluster.local`, 


mandarjog · 2017-03-30T20:29:08Z

mixer/v1/config_api_swagger.yaml

+        type: string
+      revision:
+        type: string
+        description: used for optimistic concurrency


mandarjog · 2017-03-30T20:29:15Z

mixer/v1/config_api_swagger.yaml

+      message:
+        type: string
+  aspectListMap:
+    description: map[aspectKind] aspectList


mandarjog · 2017-03-30T20:31:02Z

mixer/v1/config_api_swagger.yaml

+          $ref: '#/definitions/ruleInfo'
+  descriptor:
+    description: |
+      payload while creating and fetching descriptors. 


mandarjog · 2017-03-30T20:31:07Z

mixer/v1/config_api_swagger.yaml

+      See https://github.com/istio/api/tree/master/mixer/v1/config/descriptor for details.
+    type: object
+  adapter:
+    description: adapter definition


mandarjog · 2017-03-30T20:51:13Z

mixer/v1/config_api_swagger.yaml

+    properties:
+      kind:
+        description: |
+          optional array of kinds. It can be specified to restrict the `kinds` that the adapter provides. If kind is unspecified, it is left to the adapter  


Removed for Alpha.

Here is why it was there.
consider a GCP adapter that provides metrics, iam and logging aspects.
If I configure it as

name: default
impl: gcp
params: { }

This makes the same adapterconfig default for 3 aspects.
default-metrics, default-iam and default-logging
If I want to use prometheus as my default metrics provider, I can't do that now.
"Kind" restricts the named adapterconfig to the specified aspects.

geeknoid · 2017-03-30T20:56:26Z

mixer/v1/config_api_swagger.yaml


    * `/scopes/namespace:ns1./subjects/service:svc1.ns2./rules` is __not valid__, because svc1.ns2 __is not__ contained in namespace ns1.


-    __scope__ and __subject__ variables have the same domain with `scope >= subject`.
+    __scope__ and __subject__ draw from the same set of values with `scope >= subject`.


scope and subject draw from the same set of values as scope >= subject
makes no sense.

with specifies the constrain.

geeknoid · 2017-03-30T20:57:23Z

mixer/v1/config_api_swagger.yaml

@@ -168,11 +168,11 @@ paths:
          $ref: '#/definitions/replaceRulesRequest'
      responses:
        200:
-          description: Replaced aspect list
+          description: Replaced the list aspects


list of aspects.

geeknoid · 2017-03-30T20:58:25Z

mixer/v1/config_api_swagger.yaml

      description: |
        An adapter implementation can be instantiated with multiple sets of parameters.
-        adapter_name makes a parameter set addressable.
+        config_name makes a parameter set addressable.
      in: path
      type: string
      required: true
    put:
      operationId: replaceAdapter


replaceConfig or replaceAdapterConfig?

geeknoid · 2017-03-30T20:58:49Z

mixer/v1/config_api_swagger.yaml

      description: |
        An adapter implementation can be instantiated with multiple sets of parameters.
-        adapter_name makes a parameter set addressable.
+        config_name makes a parameter set addressable.


Is just "config" too generic? adapter_config_name maybe?

I think config_name is fine. We are already under the /adapter context.
Otherwise there is stutter.

geeknoid · 2017-03-30T20:59:48Z

mixer/v1/config_api_swagger.yaml

@@ -244,7 +244,7 @@ paths:
        200:
          description: Replaced Adapter


Replace adapter configuration.

geeknoid · 2017-03-30T21:00:06Z

mixer/v1/config_api_swagger.yaml

@@ -244,7 +244,7 @@ paths:
        200:
          description: Replaced Adapter
        403:
-          description: User not authorized for scope
+          description: Caller not authorized for scope
        404:
          description: Scope or impl_name not found


impl_name -> adapter_name

geeknoid · 2017-03-30T21:00:59Z

mixer/v1/config_api_swagger.yaml

    type: object
  policy:
-    description: list of aspect AspectRule
+    description: list of rules


list -> List

geeknoid · 2017-03-30T21:29:02Z

mixer/v1/config_api_swagger.yaml

+info:
+  version: "0.1.0"
+  title: Istio Mixer Configuration API
+  description: The mixer Configuration API allows users to configure all facets of a mixer deployment.


Configuration -> configuration

geeknoid · 2017-03-30T21:29:47Z

mixer/v1/config_api_swagger.yaml

+        items:
+          $ref: '#/definitions/ruleInfo'
+  descriptor:
+    description: |


Is | intentional?

| indicates a multi line markdown comment.

geeknoid · 2017-03-30T21:33:00Z

mixer/v1/config_api_swagger.yaml

+    get:
+      operationId: listScopes
+      description: |
+        Gets `scopes` available in the system.


In the other stop you use 'Rules' vs. 'scopes' here. Capitalization should be consistent (probably lowercase)

* Integrate mixer client directly with envoy. * Send response header in Report. * rename filter name from esp to mixer. * add README.

* Created check security rules file and a few dummy/helper functions. (istio#40) * Created check security rules file and a few dummy/helper functions. And added it to check work flow. * Fix format. * Firebase: Merge from master. (istio#53) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Enable ESP to invoke Firebase Security rules. (istio#54) * Enable ESP to invoke Firebase Security rules. * Address code review comments. * Remove some debug logs * Add proto file to capture TestRulesetRequest. * clang-format files * Resolve a merge issue with previous commit * Allow security rules to disabled via serverconfig * format file * Addressed Wayne's review comments. * Add firebase server to Server Config. * Address Lizan's review comments * Address review comments. * Disable check rules service by default. * Address more review comments. * Fix a check. * Delete unwanted constant. * Address Wayne's comments and add a simple config test. * Address a review comment. * Add negative test case for config * Address code review * Remove unwanted const std::string * Merge from master into firebase (istio#65) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Integrate with mixer client. (istio#55) * Integrate with mixer client. * Restore repositories.bzl back. * Add originIp and originHost attributes. (istio#56) * Add uuid-dev dependency in README.md (istio#45) * Extract originIp and OriginHost. (istio#57) * Extract originIp and OriginHost. * Make header x-forwarded-host const. * Update buckets for UI. (istio#58) * Update buckets for UI. * Only update time_distribution. * Add targetService attribute. (istio#59) * Use envoy new access_log handler for sending Report. (istio#60) * use access_log handler. * Not to use Loggable base class. * Update to the latest envoy with istio#396. (istio#61) * Fix tclap dependency fetching error (istio#62) * Update the auth checke to use service.experimental.authorization.providerwq! * Update the auth check to use service.experimental.authorization.provider * Update the auth check to use service.experimental.authorization.provider (istio#67) * Update the auth check to use service.experimental.authorization.provider * Address comments and revert accidental change. * Remove unnecessary added accidentally. * Another patch * fix the logic * fix lint * Fix broken test and add unit tests * Fix comments * Fix style check * revert style for raw string * fix small lint * fix small lint * fix small lint * Unit tests for check security rules. (istio#75) * Unit tests for check security rules. * format * Address review comments. * Fix typos * Merge from master to firebase (istio#143) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Integrate with mixer client. (istio#55) * Integrate with mixer client. * Restore repositories.bzl back. * Add originIp and originHost attributes. (istio#56) * Add uuid-dev dependency in README.md (istio#45) * Extract originIp and OriginHost. (istio#57) * Extract originIp and OriginHost. * Make header x-forwarded-host const. * Update buckets for UI. (istio#58) * Update buckets for UI. * Only update time_distribution. * Add targetService attribute. (istio#59) * Use envoy new access_log handler for sending Report. (istio#60) * use access_log handler. * Not to use Loggable base class. * Update to the latest envoy with istio#396. (istio#61) * Fix tclap dependency fetching error (istio#62) * Integrate mixer client directly with envoy. (istio#66) * Integrate mixer client directly with envoy. * Send response header in Report. * rename filter name from esp to mixer. * add README. * Add release binary script. (istio#68) * Push tar.gz to GCS (istio#69) * Push tar.gz to GCS * Rename envoy_esp * Remove mixer_client from api_manager. (istio#72) * Update mixer client SHA. (istio#74) * Update readme. (istio#73) * Adds Jenkinsfile and updates release-binary to create a SHA. (istio#71) * Adds Jenkinsfile and update release-binary * Update Jenkinsfile and gitignore * Fixes typo and use normal build Node * Uses default bazel config * Using batch mode * Update bazel memory settings * Do not use Jenkins bazel env * Set .bazelrc for postsubmit * Update grpc and protobuf (istio#70) * protobuf v3.2.0 * grpc v1.1.1 * Align auth lib with grpc 1.1.1 * Add sourceService. (istio#78) * Add script to build docker image. (istio#77) * Add script to build docker image. * Add start_envoy for docker image. * Use official attribute names (istio#80) * Use official attribute names * fix format * Creates a KEY for mixer client dep. Updates release-binary (istio#79) * Updated mixer repo to use a key for commit * release-binary skip build if file exists. * Update src/envoy/mixer/README. (istio#82) * Fix src/envoy/mixer/README.md (istio#85) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Not to use api_key if its service is not actived. (istio#109) * Update envoy and add c-ares (istio#107) * Update envoy and add c-ares depedencies * Update release script with debug and normal binary * remove debug ls * formatting * Send StatusCode Attributes to Mixer. (istio#110) * Add send_attribute filter. (istio#115) * Add send_attribute filter. * Fix format * rename variable serialized_attributes_ * Address the comments. * Fail request if api_key is not valid. (istio#116) * Fail request if api_key is not valid. * Format code. * Update comments. * Address comment. * Rename response.http.code (istio#125) * Send headers as string map. (istio#129) * Send headers as string map. * Remove origin.ip and origin.host. * Fix format * unify bazel's docker build targets with other istio repos (istio#127) * update base debug docker image reference (istio#133) * Update postsubmit to create docker images (istio#132) * Adding config release for bazel build (istio#135) * Fix mixer client crash. (istio#136) * Get mixerclient with response parsing. (istio#138) * Update nghttp2 to sync with envoy (istio#140) * Fix src/envoy/mixer/README.md * Update nghttp2 to sync with envoy * update * fix typo * Merge from master to firebase (istio#159) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Integrate with mixer client. (istio#55) * Integrate with mixer client. * Restore repositories.bzl back. * Add originIp and originHost attributes. (istio#56) * Add uuid-dev dependency in README.md (istio#45) * Extract originIp and OriginHost. (istio#57) * Extract originIp and OriginHost. * Make header x-forwarded-host const. * Update buckets for UI. (istio#58) * Update buckets for UI. * Only update time_distribution. * Add targetService attribute. (istio#59) * Use envoy new access_log handler for sending Report. (istio#60) * use access_log handler. * Not to use Loggable base class. * Update to the latest envoy with istio#396. (istio#61) * Fix tclap dependency fetching error (istio#62) * Integrate mixer client directly with envoy. (istio#66) * Integrate mixer client directly with envoy. * Send response header in Report. * rename filter name from esp to mixer. * add README. * Add release binary script. (istio#68) * Push tar.gz to GCS (istio#69) * Push tar.gz to GCS * Rename envoy_esp * Remove mixer_client from api_manager. (istio#72) * Update mixer client SHA. (istio#74) * Update readme. (istio#73) * Adds Jenkinsfile and updates release-binary to create a SHA. (istio#71) * Adds Jenkinsfile and update release-binary * Update Jenkinsfile and gitignore * Fixes typo and use normal build Node * Uses default bazel config * Using batch mode * Update bazel memory settings * Do not use Jenkins bazel env * Set .bazelrc for postsubmit * Update grpc and protobuf (istio#70) * protobuf v3.2.0 * grpc v1.1.1 * Align auth lib with grpc 1.1.1 * Add sourceService. (istio#78) * Add script to build docker image. (istio#77) * Add script to build docker image. * Add start_envoy for docker image. * Use official attribute names (istio#80) * Use official attribute names * fix format * Creates a KEY for mixer client dep. Updates release-binary (istio#79) * Updated mixer repo to use a key for commit * release-binary skip build if file exists. * Update src/envoy/mixer/README. (istio#82) * Fix src/envoy/mixer/README.md (istio#85) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Not to use api_key if its service is not actived. (istio#109) * Update envoy and add c-ares (istio#107) * Update envoy and add c-ares depedencies * Update release script with debug and normal binary * remove debug ls * formatting * Send StatusCode Attributes to Mixer. (istio#110) * Add send_attribute filter. (istio#115) * Add send_attribute filter. * Fix format * rename variable serialized_attributes_ * Address the comments. * Fail request if api_key is not valid. (istio#116) * Fail request if api_key is not valid. * Format code. * Update comments. * Address comment. * Rename response.http.code (istio#125) * Send headers as string map. (istio#129) * Send headers as string map. * Remove origin.ip and origin.host. * Fix format * unify bazel's docker build targets with other istio repos (istio#127) * update base debug docker image reference (istio#133) * Update postsubmit to create docker images (istio#132) * Adding config release for bazel build (istio#135) * Fix mixer client crash. (istio#136) * Get mixerclient with response parsing. (istio#138) * Update nghttp2 to sync with envoy (istio#140) * Fix src/envoy/mixer/README.md * Update nghttp2 to sync with envoy * update * fix typo * Populate origin.user attribute from the SAN field of client cert (istio#142) * Test * test * test * revert file * address comments * test * fix typo * fix format * fix format * Update to latest mixer_client. (istio#145) * Update to latest mixer_client. * Updated the sha. * Not call report if decodeHeaders is not called. (istio#150) * Update mixerclient with sync-ed grpc write and fail-fast. (istio#155) * Update mixerclient with sync-ed write and fail-fast. * Update to latest test. * Update again * Update envoy to PR553 (istio#156) * Update envoy to PR553 * Update libevent to 2.1.8 * Update the Commit id for envoy * Allow for HTTP based function from Firebase rules (istio#202) * Allow for HTTP based function from Firebase rules * Fix code style check * Added more comments. * Fix style issues. * Address code review comments from Limin and Lizan. * Add more comments and address CR comments. * Fix a typo. * Address Wayne's CR comments. * Merge from master to firebase (istio#237) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Integrate with mixer client. (istio#55) * Integrate with mixer client. * Restore repositories.bzl back. * Add originIp and originHost attributes. (istio#56) * Add uuid-dev dependency in README.md (istio#45) * Extract originIp and OriginHost. (istio#57) * Extract originIp and OriginHost. * Make header x-forwarded-host const. * Update buckets for UI. (istio#58) * Update buckets for UI. * Only update time_distribution. * Add targetService attribute. (istio#59) * Use envoy new access_log handler for sending Report. (istio#60) * use access_log handler. * Not to use Loggable base class. * Update to the latest envoy with istio#396. (istio#61) * Fix tclap dependency fetching error (istio#62) * Integrate mixer client directly with envoy. (istio#66) * Integrate mixer client directly with envoy. * Send response header in Report. * rename filter name from esp to mixer. * add README. * Add release binary script. (istio#68) * Push tar.gz to GCS (istio#69) * Push tar.gz to GCS * Rename envoy_esp * Remove mixer_client from api_manager. (istio#72) * Update mixer client SHA. (istio#74) * Update readme. (istio#73) * Adds Jenkinsfile and updates release-binary to create a SHA. (istio#71) * Adds Jenkinsfile and update release-binary * Update Jenkinsfile and gitignore * Fixes typo and use normal build Node * Uses default bazel config * Using batch mode * Update bazel memory settings * Do not use Jenkins bazel env * Set .bazelrc for postsubmit * Update grpc and protobuf (istio#70) * protobuf v3.2.0 * grpc v1.1.1 * Align auth lib with grpc 1.1.1 * Add sourceService. (istio#78) * Add script to build docker image. (istio#77) * Add script to build docker image. * Add start_envoy for docker image. * Use official attribute names (istio#80) * Use official attribute names * fix format * Creates a KEY for mixer client dep. Updates release-binary (istio#79) * Updated mixer repo to use a key for commit * release-binary skip build if file exists. * Update src/envoy/mixer/README. (istio#82) * Fix src/envoy/mixer/README.md (istio#85) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Not to use api_key if its service is not actived. (istio#109) * Update envoy and add c-ares (istio#107) * Update envoy and add c-ares depedencies * Update release script with debug and normal binary * remove debug ls * formatting * Send StatusCode Attributes to Mixer. (istio#110) * Add send_attribute filter. (istio#115) * Add send_attribute filter. * Fix format * rename variable serialized_attributes_ * Address the comments. * Fail request if api_key is not valid. (istio#116) * Fail request if api_key is not valid. * Format code. * Update comments. * Address comment. * Rename response.http.code (istio#125) * Send headers as string map. (istio#129) * Send headers as string map. * Remove origin.ip and origin.host. * Fix format * unify bazel's docker build targets with other istio repos (istio#127) * update base debug docker image reference (istio#133) * Update postsubmit to create docker images (istio#132) * Adding config release for bazel build (istio#135) * Fix mixer client crash. (istio#136) * Get mixerclient with response parsing. (istio#138) * Update nghttp2 to sync with envoy (istio#140) * Fix src/envoy/mixer/README.md * Update nghttp2 to sync with envoy * update * fix typo * Populate origin.user attribute from the SAN field of client cert (istio#142) * Test * test * test * revert file * address comments * test * fix typo * fix format * fix format * Update to latest mixer_client. (istio#145) * Update to latest mixer_client. * Updated the sha. * Not call report if decodeHeaders is not called. (istio#150) * Update mixerclient with sync-ed grpc write and fail-fast. (istio#155) * Update mixerclient with sync-ed write and fail-fast. * Update to latest test. * Update again * Update envoy to PR553 (istio#156) * Update envoy to PR553 * Update libevent to 2.1.8 * Uses a specific version of the Shared Pipeline lib (istio#158) * Update lyft/envoy commit Id to latest. (istio#161) * Update lyft/envoy commit Id to latest. * Remove the comment about pull request * Add new line - will delete in next commit. * Update repositories.bzl (istio#169) * Always set response latency (istio#172) * Update mixerclient to sync_transport change. (istio#178) * Use opaque config to turn on/off forward attribute and mixer filter (istio#179) * Modify mixer filter * Swap defaults * Make the filter decoder only * cache mixer disabled decision * Fix a bug in opaque config change and test it out (istio#182) * Fix a bug and test it out * Update filter type * Update README.md * Update mixer client to mixer api with gogoproto. (istio#184) * Move .bazelrc to tools/bazel.rc (istio#186) * Move .bazelrc to tools/bazel.rc * Update Jenkinsfile with latest version of pipeline * Support apikey based traffic restriction (istio#189) * b/36368559 support apikey based traffic restriction * Fixed code formatting * Fix crash in unreachable/overloaded RDS (istio#190) * Add mixer client end to end integration test. (istio#177) * Add mixer client end to end integration test. * Split some repositories into a separate file. * use real mixer for fake mixer_server. * Test repository * use mixer bzl file. * Use mixer repositories * Not to use mixer repository. * Add return line at the end of WORKSPACE. * Fix broken link (istio#193) * Make quota call (istio#192) * hookup quota call * Make quota call. * Update indent. * Update envoy and update configs (istio#195) * Update envoy and update configs * Use gcc-4.9 for travis * Use bazel 0.4.5 * Fix SHA of lightstep-tracer-common * Enable check cache and refactory mixer config loading (istio#197) * Refactory the mixer config loading. * fix format * Add integration test. * updated README.md * s/send/sent/ * Split into separate tests. (istio#201) * Update README on how to enable check cache. (istio#204) * Update README on how to enable check cache. * Update the comment. * build: support Envoy native Bazel build. (istio#210) * build: support Envoy native Bazel build. This patch switches the Envoy build from src/envoy/repositories.bzl to using the upstream native build. See envoyproxy/envoy#663 for the corresponding changes on the Envoy side. * Use Envoy master with BUILD.wip rename merged. * Fix clang-format issues. * Fixes bazel.rc issues (istio#212) * Fixes bazel rc issues * Update Jenkins to latest pipeline version * Fix go build (istio#224) * Use TranscoderInputStream to reduce confusion around ByteCount() (istio#225) * Add TranscoderInputStream to reduce confusion * fix_format * Merge latest changes from rate_limiting to master (istio#221) * Point to googleapi in service control client. (istio#91) * Point to googleapi in service control client. * Use git repository for service-control-client. * Merge latest changes from master (istio#104) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Extract quota config from service config. (istio#101) * Add metric_cost in config. * Remove group rules. * Call loadQuotaConfig in config::create. * Update latest update from master branch (istio#106) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Added quota contoll without the service control client library (istio#93) * Added quota contoll without the service control client library * Applied code review * Applied code review * Resolve conflicts * Resolve conflicts * Fixed format error reported by script/check-style * Fixed a bug at Aggregated::GetAuthToken that causes Segmentation Fault * Changed usage of template funcion * Applied latest changes from the repo * Applied latest changes from the repo * Applied latest changes from the repo * Adde comments * Updated log information * Applied istio#101 * Changed metric_cost_map to metric_cost_vector * Fixed test case compilation error * Fixed test case compilation error * Add unit test for quota config. (istio#108) * Add unit test for quota config. * Add comments. * Update test specifics. * Merge latest changes from master branch (istio#112) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Not to use api_key if its service is not actived. (istio#109) * If QuotaControl service is not available, return utils::Status::OK (istio#113) * If QuotaControl service is not available, return utils::Status::OK * Updated comment * Return HTTP status code 429 on google.rpc.Code.RESOURCE_EXHAUSTED (istio#119) * Fixed incorrectly resolved conflicts (istio#123) * Added unit test cases for rate limiting (istio#124) * Fixed incorrectly resolved conflicts * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Rename response.http.code (istio#125) (istio#128) * Added handling of error code QUOTA_SYSTEM_UNAVAILABLE (istio#148) * Integrated service control client library with quota cache aggregation (istio#149) * Fixed error on merge (istio#151) * Integrated service control client library with quota cache aggregation * Fixed error on merge * Fixed the compatibility issue with the latest update on esp (istio#152) * Removed copied proto files (istio#208) * Set default allocate quota request timeout to 1sec and applied latest service control client library change (istio#211) * Merged key_restriction related changes from master (istio#213) * Merge latest changes from master branch (istio#217) * Not call report if decodeHeaders is not called. (istio#150) * Update mixerclient with sync-ed grpc write and fail-fast. (istio#155) * Update mixerclient with sync-ed write and fail-fast. * Update to latest test. * Update again * Update envoy to PR553 (istio#156) * Update envoy to PR553 * Update libevent to 2.1.8 * Uses a specific version of the Shared Pipeline lib (istio#158) * Update lyft/envoy commit Id to latest. (istio#161) * Update lyft/envoy commit Id to latest. * Remove the comment about pull request * Add new line - will delete in next commit. * Update repositories.bzl (istio#169) * Always set response latency (istio#172) * Update mixerclient to sync_transport change. (istio#178) * Use opaque config to turn on/off forward attribute and mixer filter (istio#179) * Modify mixer filter * Swap defaults * Make the filter decoder only * cache mixer disabled decision * Fix a bug in opaque config change and test it out (istio#182) * Fix a bug and test it out * Update filter type * Update README.md * Update mixer client to mixer api with gogoproto. (istio#184) * Move .bazelrc to tools/bazel.rc (istio#186) * Move .bazelrc to tools/bazel.rc * Update Jenkinsfile with latest version of pipeline * Support apikey based traffic restriction (istio#189) * b/36368559 support apikey based traffic restriction * Fixed code formatting * Fix crash in unreachable/overloaded RDS (istio#190) * Add mixer client end to end integration test. (istio#177) * Add mixer client end to end integration test. * Split some repositories into a separate file. * use real mixer for fake mixer_server. * Test repository * use mixer bzl file. * Use mixer repositories * Not to use mixer repository. * Add return line at the end of WORKSPACE. * Fix broken link (istio#193) * Make quota call (istio#192) * hookup quota call * Make quota call. * Update indent. * Update envoy and update configs (istio#195) * Update envoy and update configs * Use gcc-4.9 for travis * Use bazel 0.4.5 * Fix SHA of lightstep-tracer-common * Enable check cache and refactory mixer config loading (istio#197) * Refactory the mixer config loading. * fix format * Add integration test. * updated README.md * s/send/sent/ * Split into separate tests. (istio#201) * Update README on how to enable check cache. (istio#204) * Update README on how to enable check cache. * Update the comment. * build: support Envoy native Bazel build. (istio#210) * build: support Envoy native Bazel build. This patch switches the Envoy build from src/envoy/repositories.bzl to using the upstream native build. See envoyproxy/envoy#663 for the corresponding changes on the Envoy side. * Use Envoy master with BUILD.wip rename merged. * Fix clang-format issues. * Fixes bazel.rc issues (istio#212) * Fixes bazel rc issues * Update Jenkins to latest pipeline version * Updated the commit id of cloudendpoints/service-control-client-cxx (istio#218) * Update commitid of cloudendpoints/service-control-client-cxx repo (istio#220) * Send delta metrics for intermediate reports. (istio#219) * Send delta metrics for intermediate reports. * Move last_request_bytes/last_response_bytes to RequestContext. * Handle final report. * Address comment. * Update attributes to match the canonical attribute list. (istio#232) * Update response.http.code to response.code and response.latency to response.duration to line up with the canonical attributes in istio/istio.github.io/docs/concepts/attributes.md * Format according to clang-format * Add envoy Buffer based TranscoderInputStream (istio#231) * Add envoy Buffer based TranscoderInputStream * fix format * A few doc changes for consistency across repos. (istio#235) * Add repositories.bzl * Added missing export setting in bazel configuration (istio#236) * Added export missing in bazel configuration * Added export missing in bazel configuration * Allow HTTP functions in firebase rules to specify audience (istio#244) * Allow HTTP functions in firebase rules to specify audience * Allow GetAuthToken to ignore cache and fix style checks. * Fix GetAuthToken * Address Wayne's comment * Check for empty response body * Remove .bazelrc.jenkins file not present in the master branch. * Remove forward_attribute_filter.cc not present in master.

* Log message when Stream close. * Not to call WriteDone

* Control plane updates (istio#49) * Control plane updates Signed-off-by: Liam White <[email protected]> * fix merge mistakes Signed-off-by: Liam White <[email protected]> * fix telem store comments Signed-off-by: Liam White <[email protected]> * docs: Fix single-tick (istio#50) Signed-off-by: Dhi Aurrahman <[email protected]> * add protocol to elastic settings (istio#51) * add protocol to elastic settings Signed-off-by: Liam White <[email protected]> * gogo Signed-off-by: Liam White <[email protected]> * generate fixes Signed-off-by: Liam White <[email protected]> * Add job annotations for components with jobs (istio#52) * Add container port and service types + refactor (istio#56) * Add container port and service types + refactor Signed-off-by: Liam White <[email protected]> * makefile and comment touch-ups Signed-off-by: Liam White <[email protected]> * Make Istio install atomic and add more currently used fields (istio#61) * Fix TLS capitalization (istio#62) * Add proto for some more postgres configuration (istio#53) * Add proto for some more postgres configuration * Address comments * More comments * Add Escape Hatch for users with weird edge cases (istio#65) Also need to move back to golang protobuf in order to re-use the Istio patch framework. * Use older Istio API to avoid breaking dp operator (istio#66) * Postgres SSL settings (istio#67) * Postgres SSL settings * Update install/managementplane/v1alpha1/settings.proto Co-authored-by: Liam White <[email protected]> * Update install/managementplane/v1alpha1/settings.proto Co-authored-by: Liam White <[email protected]> * Add remaining SSL modes Co-authored-by: Liam White <[email protected]> * Configure CNI (istio#68) * Configure CNI * review Signed-off-by: Liam White <[email protected]> * Add CNI config file name, used when chained is false Co-authored-by: Liam White <[email protected]> * Revert "Postgres SSL settings (istio#67)" (istio#70) * Revert "Postgres SSL settings (istio#67)" This reverts commit 391889fdaf5bfa3996c85719975df1c44ce94102. * Add back all ssl modes * Doc Fixes for Install API (istio#71) * ci: Add check (istio#73) This patch brings the check script to release-0.8.0. Seems like this is the new "master". Signed-off-by: Dhi Aurrahman <[email protected]> * docs: Add types frontmatter (istio#74) This adds types frontmatter data to types.proto. Until we have an automated way to populate title, we are encouraged to add a title when it is desired. Signed-off-by: Dhi Aurrahman <[email protected]> * Postgres SSL mode default to require (istio#75) * Autogen JSON shims (istio#80) * nits * Update install readme (istio#85) * Add ES version to settings (istio#88) * Add ES version to settings * ES version int with validation Co-authored-by: Liam White <[email protected]> Co-authored-by: Dhi Aurrahman <[email protected]> Co-authored-by: Vikas Choudhary (vikasc) <[email protected]> Co-authored-by: Marc Cirauqui <[email protected]> This PR merges the release_0.8.0 (as of commit - d3a19fdd8d25cdd8f386c4a4a2a821daa9865df0) branch into master. operator protos needs go_plugin instead of gogofast_plugin for the protoc. It is as is merge otherwise.

Add mixer config api swagger with a link to doc

90ad2b7

mandarjog requested review from smawson, wora, geeknoid and rshriram March 30, 2017 17:36

geeknoid reviewed Mar 30, 2017

View reviewed changes

review comments1

962832e

mandarjog commented Mar 30, 2017

View reviewed changes

geeknoid reviewed Mar 30, 2017

View reviewed changes

review comments + fix description punctuations

f78bcc6

mandarjog force-pushed the config_api branch from 62e2450 to f78bcc6 Compare March 30, 2017 21:19

geeknoid approved these changes Mar 30, 2017

View reviewed changes

Update capitalization

cdf1cae

mandarjog merged commit eead222 into istio:master Mar 30, 2017

incfly pushed a commit to incfly/api that referenced this pull request Jun 13, 2018

Integrate mixer client directly with envoy. (istio#66)

33f54ed

* Integrate mixer client directly with envoy. * Send response header in Report. * rename filter name from esp to mixer. * add README.

incfly pushed a commit to incfly/api that referenced this pull request Jun 13, 2018

Log message when Stream close. (istio#66)

12e9787

* Log message when Stream close. * Not to call WriteDone

Mixer config api swagger with a link to doc #66

Mixer config api swagger with a link to doc #66

Uh oh!

Conversation

mandarjog commented Mar 30, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mandarjog left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment