Update mixer descriptor protos to be consistent #49
Comments
|
Any explanation about the difference between attribute descriptor and label descriptor? |
|
They are very similar structurally, but have different semantics: labels dimension other things in the system (metrics, quotas, logs, etc), while attributes describe values the system knows about at runtime. If labels used the @geeknoid your thoughts here? |
|
I think you captured it succinctly. Attributes and labels live in different namespaces and serve different purposes. Attributes provide metadata about an individual request and the environment in which it runs in. We use attributes to apply policies. Labels on the other hand are output state from config evaluation, representing inputs to our adapters. |
incfly
pushed a commit
to incfly/api
that referenced
this issue
Jun 13, 2018
incfly
pushed a commit
to incfly/api
that referenced
this issue
Jun 13, 2018
incfly
pushed a commit
to incfly/api
that referenced
this issue
Jun 13, 2018
* Created check security rules file and a few dummy/helper functions. (istio#40) * Created check security rules file and a few dummy/helper functions. And added it to check work flow. * Fix format. * Firebase: Merge from master. (istio#53) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Enable ESP to invoke Firebase Security rules. (istio#54) * Enable ESP to invoke Firebase Security rules. * Address code review comments. * Remove some debug logs * Add proto file to capture TestRulesetRequest. * clang-format files * Resolve a merge issue with previous commit * Allow security rules to disabled via serverconfig * format file * Addressed Wayne's review comments. * Add firebase server to Server Config. * Address Lizan's review comments * Address review comments. * Disable check rules service by default. * Address more review comments. * Fix a check. * Delete unwanted constant. * Address Wayne's comments and add a simple config test. * Address a review comment. * Add negative test case for config * Address code review * Remove unwanted const std::string * Merge from master into firebase (istio#65) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Integrate with mixer client. (istio#55) * Integrate with mixer client. * Restore repositories.bzl back. * Add originIp and originHost attributes. (istio#56) * Add uuid-dev dependency in README.md (istio#45) * Extract originIp and OriginHost. (istio#57) * Extract originIp and OriginHost. * Make header x-forwarded-host const. * Update buckets for UI. (istio#58) * Update buckets for UI. * Only update time_distribution. * Add targetService attribute. (istio#59) * Use envoy new access_log handler for sending Report. (istio#60) * use access_log handler. * Not to use Loggable base class. * Update to the latest envoy with istio#396. (istio#61) * Fix tclap dependency fetching error (istio#62) * Update the auth checke to use service.experimental.authorization.providerwq! * Update the auth check to use service.experimental.authorization.provider * Update the auth check to use service.experimental.authorization.provider (istio#67) * Update the auth check to use service.experimental.authorization.provider * Address comments and revert accidental change. * Remove unnecessary added accidentally. * Another patch * fix the logic * fix lint * Fix broken test and add unit tests * Fix comments * Fix style check * revert style for raw string * fix small lint * fix small lint * fix small lint * Unit tests for check security rules. (istio#75) * Unit tests for check security rules. * format * Address review comments. * Fix typos * Merge from master to firebase (istio#143) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Integrate with mixer client. (istio#55) * Integrate with mixer client. * Restore repositories.bzl back. * Add originIp and originHost attributes. (istio#56) * Add uuid-dev dependency in README.md (istio#45) * Extract originIp and OriginHost. (istio#57) * Extract originIp and OriginHost. * Make header x-forwarded-host const. * Update buckets for UI. (istio#58) * Update buckets for UI. * Only update time_distribution. * Add targetService attribute. (istio#59) * Use envoy new access_log handler for sending Report. (istio#60) * use access_log handler. * Not to use Loggable base class. * Update to the latest envoy with istio#396. (istio#61) * Fix tclap dependency fetching error (istio#62) * Integrate mixer client directly with envoy. (istio#66) * Integrate mixer client directly with envoy. * Send response header in Report. * rename filter name from esp to mixer. * add README. * Add release binary script. (istio#68) * Push tar.gz to GCS (istio#69) * Push tar.gz to GCS * Rename envoy_esp * Remove mixer_client from api_manager. (istio#72) * Update mixer client SHA. (istio#74) * Update readme. (istio#73) * Adds Jenkinsfile and updates release-binary to create a SHA. (istio#71) * Adds Jenkinsfile and update release-binary * Update Jenkinsfile and gitignore * Fixes typo and use normal build Node * Uses default bazel config * Using batch mode * Update bazel memory settings * Do not use Jenkins bazel env * Set .bazelrc for postsubmit * Update grpc and protobuf (istio#70) * protobuf v3.2.0 * grpc v1.1.1 * Align auth lib with grpc 1.1.1 * Add sourceService. (istio#78) * Add script to build docker image. (istio#77) * Add script to build docker image. * Add start_envoy for docker image. * Use official attribute names (istio#80) * Use official attribute names * fix format * Creates a KEY for mixer client dep. Updates release-binary (istio#79) * Updated mixer repo to use a key for commit * release-binary skip build if file exists. * Update src/envoy/mixer/README. (istio#82) * Fix src/envoy/mixer/README.md (istio#85) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Not to use api_key if its service is not actived. (istio#109) * Update envoy and add c-ares (istio#107) * Update envoy and add c-ares depedencies * Update release script with debug and normal binary * remove debug ls * formatting * Send StatusCode Attributes to Mixer. (istio#110) * Add send_attribute filter. (istio#115) * Add send_attribute filter. * Fix format * rename variable serialized_attributes_ * Address the comments. * Fail request if api_key is not valid. (istio#116) * Fail request if api_key is not valid. * Format code. * Update comments. * Address comment. * Rename response.http.code (istio#125) * Send headers as string map. (istio#129) * Send headers as string map. * Remove origin.ip and origin.host. * Fix format * unify bazel's docker build targets with other istio repos (istio#127) * update base debug docker image reference (istio#133) * Update postsubmit to create docker images (istio#132) * Adding config release for bazel build (istio#135) * Fix mixer client crash. (istio#136) * Get mixerclient with response parsing. (istio#138) * Update nghttp2 to sync with envoy (istio#140) * Fix src/envoy/mixer/README.md * Update nghttp2 to sync with envoy * update * fix typo * Merge from master to firebase (istio#159) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Integrate with mixer client. (istio#55) * Integrate with mixer client. * Restore repositories.bzl back. * Add originIp and originHost attributes. (istio#56) * Add uuid-dev dependency in README.md (istio#45) * Extract originIp and OriginHost. (istio#57) * Extract originIp and OriginHost. * Make header x-forwarded-host const. * Update buckets for UI. (istio#58) * Update buckets for UI. * Only update time_distribution. * Add targetService attribute. (istio#59) * Use envoy new access_log handler for sending Report. (istio#60) * use access_log handler. * Not to use Loggable base class. * Update to the latest envoy with istio#396. (istio#61) * Fix tclap dependency fetching error (istio#62) * Integrate mixer client directly with envoy. (istio#66) * Integrate mixer client directly with envoy. * Send response header in Report. * rename filter name from esp to mixer. * add README. * Add release binary script. (istio#68) * Push tar.gz to GCS (istio#69) * Push tar.gz to GCS * Rename envoy_esp * Remove mixer_client from api_manager. (istio#72) * Update mixer client SHA. (istio#74) * Update readme. (istio#73) * Adds Jenkinsfile and updates release-binary to create a SHA. (istio#71) * Adds Jenkinsfile and update release-binary * Update Jenkinsfile and gitignore * Fixes typo and use normal build Node * Uses default bazel config * Using batch mode * Update bazel memory settings * Do not use Jenkins bazel env * Set .bazelrc for postsubmit * Update grpc and protobuf (istio#70) * protobuf v3.2.0 * grpc v1.1.1 * Align auth lib with grpc 1.1.1 * Add sourceService. (istio#78) * Add script to build docker image. (istio#77) * Add script to build docker image. * Add start_envoy for docker image. * Use official attribute names (istio#80) * Use official attribute names * fix format * Creates a KEY for mixer client dep. Updates release-binary (istio#79) * Updated mixer repo to use a key for commit * release-binary skip build if file exists. * Update src/envoy/mixer/README. (istio#82) * Fix src/envoy/mixer/README.md (istio#85) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Not to use api_key if its service is not actived. (istio#109) * Update envoy and add c-ares (istio#107) * Update envoy and add c-ares depedencies * Update release script with debug and normal binary * remove debug ls * formatting * Send StatusCode Attributes to Mixer. (istio#110) * Add send_attribute filter. (istio#115) * Add send_attribute filter. * Fix format * rename variable serialized_attributes_ * Address the comments. * Fail request if api_key is not valid. (istio#116) * Fail request if api_key is not valid. * Format code. * Update comments. * Address comment. * Rename response.http.code (istio#125) * Send headers as string map. (istio#129) * Send headers as string map. * Remove origin.ip and origin.host. * Fix format * unify bazel's docker build targets with other istio repos (istio#127) * update base debug docker image reference (istio#133) * Update postsubmit to create docker images (istio#132) * Adding config release for bazel build (istio#135) * Fix mixer client crash. (istio#136) * Get mixerclient with response parsing. (istio#138) * Update nghttp2 to sync with envoy (istio#140) * Fix src/envoy/mixer/README.md * Update nghttp2 to sync with envoy * update * fix typo * Populate origin.user attribute from the SAN field of client cert (istio#142) * Test * test * test * revert file * address comments * test * fix typo * fix format * fix format * Update to latest mixer_client. (istio#145) * Update to latest mixer_client. * Updated the sha. * Not call report if decodeHeaders is not called. (istio#150) * Update mixerclient with sync-ed grpc write and fail-fast. (istio#155) * Update mixerclient with sync-ed write and fail-fast. * Update to latest test. * Update again * Update envoy to PR553 (istio#156) * Update envoy to PR553 * Update libevent to 2.1.8 * Update the Commit id for envoy * Allow for HTTP based function from Firebase rules (istio#202) * Allow for HTTP based function from Firebase rules * Fix code style check * Added more comments. * Fix style issues. * Address code review comments from Limin and Lizan. * Add more comments and address CR comments. * Fix a typo. * Address Wayne's CR comments. * Merge from master to firebase (istio#237) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect (istio#38) * Simple TCP server to show how to retrieve original dest IP:port after an iptables redirect * Fixed style. * Rebase Envoy (istio#41) * Update prototype to use iptables (istio#42) * Rebase to fixed Envoy (istio#43) * Handle HEAD request. (istio#34) * Handle HEAD request. * Try with GET if HEAD fails. * Address comments. * Format file. * Expose bazel target (istio#48) * Try again (istio#49) * Integrate with mixer client. (istio#55) * Integrate with mixer client. * Restore repositories.bzl back. * Add originIp and originHost attributes. (istio#56) * Add uuid-dev dependency in README.md (istio#45) * Extract originIp and OriginHost. (istio#57) * Extract originIp and OriginHost. * Make header x-forwarded-host const. * Update buckets for UI. (istio#58) * Update buckets for UI. * Only update time_distribution. * Add targetService attribute. (istio#59) * Use envoy new access_log handler for sending Report. (istio#60) * use access_log handler. * Not to use Loggable base class. * Update to the latest envoy with istio#396. (istio#61) * Fix tclap dependency fetching error (istio#62) * Integrate mixer client directly with envoy. (istio#66) * Integrate mixer client directly with envoy. * Send response header in Report. * rename filter name from esp to mixer. * add README. * Add release binary script. (istio#68) * Push tar.gz to GCS (istio#69) * Push tar.gz to GCS * Rename envoy_esp * Remove mixer_client from api_manager. (istio#72) * Update mixer client SHA. (istio#74) * Update readme. (istio#73) * Adds Jenkinsfile and updates release-binary to create a SHA. (istio#71) * Adds Jenkinsfile and update release-binary * Update Jenkinsfile and gitignore * Fixes typo and use normal build Node * Uses default bazel config * Using batch mode * Update bazel memory settings * Do not use Jenkins bazel env * Set .bazelrc for postsubmit * Update grpc and protobuf (istio#70) * protobuf v3.2.0 * grpc v1.1.1 * Align auth lib with grpc 1.1.1 * Add sourceService. (istio#78) * Add script to build docker image. (istio#77) * Add script to build docker image. * Add start_envoy for docker image. * Use official attribute names (istio#80) * Use official attribute names * fix format * Creates a KEY for mixer client dep. Updates release-binary (istio#79) * Updated mixer repo to use a key for commit * release-binary skip build if file exists. * Update src/envoy/mixer/README. (istio#82) * Fix src/envoy/mixer/README.md (istio#85) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Not to use api_key if its service is not actived. (istio#109) * Update envoy and add c-ares (istio#107) * Update envoy and add c-ares depedencies * Update release script with debug and normal binary * remove debug ls * formatting * Send StatusCode Attributes to Mixer. (istio#110) * Add send_attribute filter. (istio#115) * Add send_attribute filter. * Fix format * rename variable serialized_attributes_ * Address the comments. * Fail request if api_key is not valid. (istio#116) * Fail request if api_key is not valid. * Format code. * Update comments. * Address comment. * Rename response.http.code (istio#125) * Send headers as string map. (istio#129) * Send headers as string map. * Remove origin.ip and origin.host. * Fix format * unify bazel's docker build targets with other istio repos (istio#127) * update base debug docker image reference (istio#133) * Update postsubmit to create docker images (istio#132) * Adding config release for bazel build (istio#135) * Fix mixer client crash. (istio#136) * Get mixerclient with response parsing. (istio#138) * Update nghttp2 to sync with envoy (istio#140) * Fix src/envoy/mixer/README.md * Update nghttp2 to sync with envoy * update * fix typo * Populate origin.user attribute from the SAN field of client cert (istio#142) * Test * test * test * revert file * address comments * test * fix typo * fix format * fix format * Update to latest mixer_client. (istio#145) * Update to latest mixer_client. * Updated the sha. * Not call report if decodeHeaders is not called. (istio#150) * Update mixerclient with sync-ed grpc write and fail-fast. (istio#155) * Update mixerclient with sync-ed write and fail-fast. * Update to latest test. * Update again * Update envoy to PR553 (istio#156) * Update envoy to PR553 * Update libevent to 2.1.8 * Uses a specific version of the Shared Pipeline lib (istio#158) * Update lyft/envoy commit Id to latest. (istio#161) * Update lyft/envoy commit Id to latest. * Remove the comment about pull request * Add new line - will delete in next commit. * Update repositories.bzl (istio#169) * Always set response latency (istio#172) * Update mixerclient to sync_transport change. (istio#178) * Use opaque config to turn on/off forward attribute and mixer filter (istio#179) * Modify mixer filter * Swap defaults * Make the filter decoder only * cache mixer disabled decision * Fix a bug in opaque config change and test it out (istio#182) * Fix a bug and test it out * Update filter type * Update README.md * Update mixer client to mixer api with gogoproto. (istio#184) * Move .bazelrc to tools/bazel.rc (istio#186) * Move .bazelrc to tools/bazel.rc * Update Jenkinsfile with latest version of pipeline * Support apikey based traffic restriction (istio#189) * b/36368559 support apikey based traffic restriction * Fixed code formatting * Fix crash in unreachable/overloaded RDS (istio#190) * Add mixer client end to end integration test. (istio#177) * Add mixer client end to end integration test. * Split some repositories into a separate file. * use real mixer for fake mixer_server. * Test repository * use mixer bzl file. * Use mixer repositories * Not to use mixer repository. * Add return line at the end of WORKSPACE. * Fix broken link (istio#193) * Make quota call (istio#192) * hookup quota call * Make quota call. * Update indent. * Update envoy and update configs (istio#195) * Update envoy and update configs * Use gcc-4.9 for travis * Use bazel 0.4.5 * Fix SHA of lightstep-tracer-common * Enable check cache and refactory mixer config loading (istio#197) * Refactory the mixer config loading. * fix format * Add integration test. * updated README.md * s/send/sent/ * Split into separate tests. (istio#201) * Update README on how to enable check cache. (istio#204) * Update README on how to enable check cache. * Update the comment. * build: support Envoy native Bazel build. (istio#210) * build: support Envoy native Bazel build. This patch switches the Envoy build from src/envoy/repositories.bzl to using the upstream native build. See envoyproxy/envoy#663 for the corresponding changes on the Envoy side. * Use Envoy master with BUILD.wip rename merged. * Fix clang-format issues. * Fixes bazel.rc issues (istio#212) * Fixes bazel rc issues * Update Jenkins to latest pipeline version * Fix go build (istio#224) * Use TranscoderInputStream to reduce confusion around ByteCount() (istio#225) * Add TranscoderInputStream to reduce confusion * fix_format * Merge latest changes from rate_limiting to master (istio#221) * Point to googleapi in service control client. (istio#91) * Point to googleapi in service control client. * Use git repository for service-control-client. * Merge latest changes from master (istio#104) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Extract quota config from service config. (istio#101) * Add metric_cost in config. * Remove group rules. * Call loadQuotaConfig in config::create. * Update latest update from master branch (istio#106) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Added quota contoll without the service control client library (istio#93) * Added quota contoll without the service control client library * Applied code review * Applied code review * Resolve conflicts * Resolve conflicts * Fixed format error reported by script/check-style * Fixed a bug at Aggregated::GetAuthToken that causes Segmentation Fault * Changed usage of template funcion * Applied latest changes from the repo * Applied latest changes from the repo * Applied latest changes from the repo * Adde comments * Updated log information * Applied istio#101 * Changed metric_cost_map to metric_cost_vector * Fixed test case compilation error * Fixed test case compilation error * Add unit test for quota config. (istio#108) * Add unit test for quota config. * Add comments. * Update test specifics. * Merge latest changes from master branch (istio#112) * Get attributes from envoy config. (istio#87) * Send all attributes. * Remove unused const strings. * Address comment. * updated SHA to point to newer envoy with RDS API feature (istio#94) * Disable travis on stable branches (istio#96) * Publish debug binaries (no release yet) (istio#98) * Copies the binary instead of linking for release (istio#102) * Not to use api_key if its service is not actived. (istio#109) * If QuotaControl service is not available, return utils::Status::OK (istio#113) * If QuotaControl service is not available, return utils::Status::OK * Updated comment * Return HTTP status code 429 on google.rpc.Code.RESOURCE_EXHAUSTED (istio#119) * Fixed incorrectly resolved conflicts (istio#123) * Added unit test cases for rate limiting (istio#124) * Fixed incorrectly resolved conflicts * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Added unit test cases for rate limiting * Rename response.http.code (istio#125) (istio#128) * Added handling of error code QUOTA_SYSTEM_UNAVAILABLE (istio#148) * Integrated service control client library with quota cache aggregation (istio#149) * Fixed error on merge (istio#151) * Integrated service control client library with quota cache aggregation * Fixed error on merge * Fixed the compatibility issue with the latest update on esp (istio#152) * Removed copied proto files (istio#208) * Set default allocate quota request timeout to 1sec and applied latest service control client library change (istio#211) * Merged key_restriction related changes from master (istio#213) * Merge latest changes from master branch (istio#217) * Not call report if decodeHeaders is not called. (istio#150) * Update mixerclient with sync-ed grpc write and fail-fast. (istio#155) * Update mixerclient with sync-ed write and fail-fast. * Update to latest test. * Update again * Update envoy to PR553 (istio#156) * Update envoy to PR553 * Update libevent to 2.1.8 * Uses a specific version of the Shared Pipeline lib (istio#158) * Update lyft/envoy commit Id to latest. (istio#161) * Update lyft/envoy commit Id to latest. * Remove the comment about pull request * Add new line - will delete in next commit. * Update repositories.bzl (istio#169) * Always set response latency (istio#172) * Update mixerclient to sync_transport change. (istio#178) * Use opaque config to turn on/off forward attribute and mixer filter (istio#179) * Modify mixer filter * Swap defaults * Make the filter decoder only * cache mixer disabled decision * Fix a bug in opaque config change and test it out (istio#182) * Fix a bug and test it out * Update filter type * Update README.md * Update mixer client to mixer api with gogoproto. (istio#184) * Move .bazelrc to tools/bazel.rc (istio#186) * Move .bazelrc to tools/bazel.rc * Update Jenkinsfile with latest version of pipeline * Support apikey based traffic restriction (istio#189) * b/36368559 support apikey based traffic restriction * Fixed code formatting * Fix crash in unreachable/overloaded RDS (istio#190) * Add mixer client end to end integration test. (istio#177) * Add mixer client end to end integration test. * Split some repositories into a separate file. * use real mixer for fake mixer_server. * Test repository * use mixer bzl file. * Use mixer repositories * Not to use mixer repository. * Add return line at the end of WORKSPACE. * Fix broken link (istio#193) * Make quota call (istio#192) * hookup quota call * Make quota call. * Update indent. * Update envoy and update configs (istio#195) * Update envoy and update configs * Use gcc-4.9 for travis * Use bazel 0.4.5 * Fix SHA of lightstep-tracer-common * Enable check cache and refactory mixer config loading (istio#197) * Refactory the mixer config loading. * fix format * Add integration test. * updated README.md * s/send/sent/ * Split into separate tests. (istio#201) * Update README on how to enable check cache. (istio#204) * Update README on how to enable check cache. * Update the comment. * build: support Envoy native Bazel build. (istio#210) * build: support Envoy native Bazel build. This patch switches the Envoy build from src/envoy/repositories.bzl to using the upstream native build. See envoyproxy/envoy#663 for the corresponding changes on the Envoy side. * Use Envoy master with BUILD.wip rename merged. * Fix clang-format issues. * Fixes bazel.rc issues (istio#212) * Fixes bazel rc issues * Update Jenkins to latest pipeline version * Updated the commit id of cloudendpoints/service-control-client-cxx (istio#218) * Update commitid of cloudendpoints/service-control-client-cxx repo (istio#220) * Send delta metrics for intermediate reports. (istio#219) * Send delta metrics for intermediate reports. * Move last_request_bytes/last_response_bytes to RequestContext. * Handle final report. * Address comment. * Update attributes to match the canonical attribute list. (istio#232) * Update response.http.code to response.code and response.latency to response.duration to line up with the canonical attributes in istio/istio.github.io/docs/concepts/attributes.md * Format according to clang-format * Add envoy Buffer based TranscoderInputStream (istio#231) * Add envoy Buffer based TranscoderInputStream * fix format * A few doc changes for consistency across repos. (istio#235) * Add repositories.bzl * Added missing export setting in bazel configuration (istio#236) * Added export missing in bazel configuration * Added export missing in bazel configuration * Allow HTTP functions in firebase rules to specify audience (istio#244) * Allow HTTP functions in firebase rules to specify audience * Allow GetAuthToken to ignore cache and fix style checks. * Fix GetAuthToken * Address Wayne's comment * Check for empty response body * Remove .bazelrc.jenkins file not present in the master branch. * Remove forward_attribute_filter.cc not present in master.
nacx
pushed a commit
to nacx/api
that referenced
this issue
Apr 15, 2020
* Added onboarding APIs * Fetch service principals when fetching users * API method to bind services to policies (groups) * Basic import users and group implementation * Better comments in proto files * Added filtering capabilities to the onboarding interfaces Mirrored from https://github.com/tetrateio/tetrate @ 10098936c9351756011208a21611601886a452c5
nacx
pushed a commit
to nacx/api
that referenced
this issue
Apr 15, 2020
* Service Inventory gRPC server integration - server main should to utilize cobra command-line - Dockerfile to include "--server-name" param - minor gRPC server fix: NewTracer could return nil io.Closer - Jaeger ReporterConfig post endpoint should be CollectorEndpoint (instead of LocalAgentHostPort?) * First-cut pilot xDS interface routines for obtaining service inventory from Istio Pilot. Includes the following: - Routine to Connect to pilot - Send CDS/EDS streaming requests - Receive and handle DiscoveryResponse responses - Unmarshal clusters, and endpoints and print them - Test routine for above steps * Unmarshal CDS/EDS into Tetrate Service proto compatible - Separate out unmarshal CDS & EDS streams; each of those return tetrate.Service protos to be used to populate DB - Stitch Cluster/Endpoint fields into appropriate Service/Endpoint fields * chaned pkg name and a fix in jaegar.go * Service Inventory gRPC server integration - server main should to utilize cobra command-line - Dockerfile to include "--server-name" param - minor gRPC server fix: NewTracer could return nil io.Closer - Jaeger ReporterConfig post endpoint should be CollectorEndpoint (instead of LocalAgentHostPort?) * minor changes to fix errors * xDS CDS/EDS inventory with following further changes: - Renamed pkg/client to pkg/xdsclient; package renamed to xdsclient - Updated PLSQL file to update/insert services if not unique (occurs 2 times) - cmd/test-data/main.go now includes psql.CreateService() for populating DB services, clusters, endpoints, etc. - Minor fixes, compilation issues * first cut of xdsclient * Service Inventory/plsql change accommodating the following: - Delete list of services; plsql routines and sql routines for same - Makefile phony to include protos (force descriptor generation everytime) * Fixed compilation issues in cmd/test-data * Soft-delete service entries - Mark service deleted using Service.Status field enum - Update PLSQL delete_services() macro to update status field * fixes after testing.. * Further updates to xDS client and DB interfacing: - Integrate xdsclient code to server - Invoke DB updates with appropriate context - Added CreateServices([]Services) * re-arranged calling Unmarshall, test function change * First-cut pilot xDS interface routines for obtaining service inventory from Istio Pilot. Includes the following: - Routine to Connect to pilot - Send CDS/EDS streaming requests - Receive and handle DiscoveryResponse responses - Unmarshal clusters, and endpoints and print them - Test routine for above steps * Unmarshal CDS/EDS into Tetrate Service proto compatible - Separate out unmarshal CDS & EDS streams; each of those return tetrate.Service protos to be used to populate DB - Stitch Cluster/Endpoint fields into appropriate Service/Endpoint fields * chaned pkg name and a fix in jaegar.go * minor changes to fix errors * xDS CDS/EDS inventory with following further changes: - Renamed pkg/client to pkg/xdsclient; package renamed to xdsclient - Updated PLSQL file to update/insert services if not unique (occurs 2 times) - cmd/test-data/main.go now includes psql.CreateService() for populating DB services, clusters, endpoints, etc. - Minor fixes, compilation issues * first cut of xdsclient * Service Inventory/plsql change accommodating the following: - Delete list of services; plsql routines and sql routines for same - Makefile phony to include protos (force descriptor generation everytime) * Fixed compilation issues in cmd/test-data * fixes after testing.. * Further updates to xDS client and DB interfacing: - Integrate xdsclient code to server - Invoke DB updates with appropriate context - Added CreateServices([]Services) * re-arranged calling Unmarshall, test function change * Service/cluster DB updates incorporating the following: - Added cluster.name constraint for uniqueness required for ON CONFLICT updates - PLSQL delete_services() macro to delete all services, if no services string provided - Invoke delete prior to EDS updates * Service/cluster DB updates incorporating the following: - Added cluster.name constraint for uniqueness required for ON CONFLICT updates - delete_services() DB macro to delete all services, if no services string provided - Invoke delete prior to EDS updates * Minor Updates to Service Inventory xDS interfaces - Renamed pkg/xdsclient/xds_resp_unmarshall.go to xds_unmarshal.go - enum types for CDS/EDS type URLs - Removed unnecessary logs/prints in responses * Multiple Istio Pilot interfaces (change istio#1): Bring in grpc_server changes with appropriate command-line to inventory-server; Updated interface to use array of pilot addresses * Added :authority to work with VirtualService * Handling array of pilots * Addressed PR Comments, Moved xdsclient_test.go to different dir * Service Inventory gRPC server integration (istio#35) * Service Inventory gRPC server integration - server main should to utilize cobra command-line - Dockerfile to include "--server-name" param - minor gRPC server fix: NewTracer could return nil io.Closer - Jaeger ReporterConfig post endpoint should be CollectorEndpoint (instead of LocalAgentHostPort?) * Moving "--server-name" flags to deployment from Dockerfile. Earlier commits (4c45233) are still valid. * Azure onboarding improvements (istio#50) * Automatically onboard all subscriptions * Better look for user emails * Unified Makefiles * Added onboarding APIs (istio#49) * Added onboarding APIs * Fetch service principals when fetching users * API method to bind services to policies (groups) * Basic import users and group implementation * Better comments in proto files * Added filtering capabilities to the onboarding interfaces * Service Inventory with cached updates: - Handling of multiple pilot addresses - Common cached/incremental update framework - cached DB updates to DB; Update services to do add/mod/del DB updates * Minor fix to Gopkg.lock to use correct prometheus client_golang revision * mTLS changes; UT changes * removed certs and fixed errors in yaml * Minor changes to cache infra - Cache tests for add/mod/delete, list and delta updates - Cache to use keyFunc instead of service-specific function; moving service key to plsql pkg * Minor fixes to unit test, and earlier PR review comments; Use map to gather list of locality zones sent to service * mtls fixes and templatization * minor fix * UT fix * changes to xdshandler to take a map * Service Category improvement fixes addressing the following: - Added cloud provider based on zone/locality - header inclusions, and updated variables (post rebase) - Gopkg fixes * changed intermediary cert validity to 365 days - PR Comment * Service Catalog PR fixes, and minor improvements: - Addressed PR fixes except cache, SQL library for queries (will cover next) - Ensure atleast one endpoint in identifying provider - Using pkg/logs instead - Use third_party/protobuf for proto compilation - Added inventory.proto-descriptor to .gitignore * Minor updates to Service Inventory in branch to enable correct compilation packages; Updated tetrate.sql with (missed) merge changes from master * move xdsclient_test.go to /test - PR comment * Service Inventory improvement fixes addressing the following: - Cache wrapper on top of istio cache supporting custom key/equal/deltas; moved cache to pkg/cache - plsql/service.go now initializes a service-specific cache instance for local package operations - Moved out service-related routines into plsql/service.go - Replaced PLSQL macros calls with sql prepare tx context across insert/queries - PLSQL tetrate.sql tables with correct primary keys/constraints - fixed deployment yaml missing mount/secret stanzas (rebase merge issue) - Addressed all other PR comments * Ridding of istio constraints in Gopkg.toml; also CircleCI build fails resolving to 1.0.0 * Service Catalog improvements incorporating the following: - Addressed all PR comments across packages - Included bunch relevant unit tests - Used errors.Wrap for annotated errors with stack trace, pkg/log, and t.log * Addressing PR Comments by zack * Fixed minor compilation issues post rebase to master * Added UT tests for cache expiry/eviction, and cloud providers * Minor compilation issues fixed post rebase to master * Incorporated recent PR comments including the following: - Endpoint now handles IPv4/v6 addresses - Moved Service (ListServices), and Service binding routines into plsql/service.go - Added log context to pkg/cache - api/inventory/v1/Makefile won't force rebuilding of proto sources (make CircleCI happy) - Included log/errors/debug specific to package as appropriate - Fixes to golinter, imports, formatting & statement recommendations Mirrored from https://github.com/tetrateio/tetrate @ 38397984da9b30a32eac5cb6fca59adba80ce578
nacx
pushed a commit
to nacx/api
that referenced
this issue
Feb 23, 2022
* Control plane updates Signed-off-by: Liam White <[email protected]> * fix merge mistakes Signed-off-by: Liam White <[email protected]> * fix telem store comments Signed-off-by: Liam White <[email protected]>
nacx
pushed a commit
to nacx/api
that referenced
this issue
Feb 23, 2022
* Control plane updates (istio#49) * Control plane updates Signed-off-by: Liam White <[email protected]> * fix merge mistakes Signed-off-by: Liam White <[email protected]> * fix telem store comments Signed-off-by: Liam White <[email protected]> * docs: Fix single-tick (istio#50) Signed-off-by: Dhi Aurrahman <[email protected]> * add protocol to elastic settings (istio#51) * add protocol to elastic settings Signed-off-by: Liam White <[email protected]> * gogo Signed-off-by: Liam White <[email protected]> * generate fixes Signed-off-by: Liam White <[email protected]> * Add job annotations for components with jobs (istio#52) * Add container port and service types + refactor (istio#56) * Add container port and service types + refactor Signed-off-by: Liam White <[email protected]> * makefile and comment touch-ups Signed-off-by: Liam White <[email protected]> * Make Istio install atomic and add more currently used fields (istio#61) * Fix TLS capitalization (istio#62) * Add proto for some more postgres configuration (istio#53) * Add proto for some more postgres configuration * Address comments * More comments * Add Escape Hatch for users with weird edge cases (istio#65) Also need to move back to golang protobuf in order to re-use the Istio patch framework. * Use older Istio API to avoid breaking dp operator (istio#66) * Postgres SSL settings (istio#67) * Postgres SSL settings * Update install/managementplane/v1alpha1/settings.proto Co-authored-by: Liam White <[email protected]> * Update install/managementplane/v1alpha1/settings.proto Co-authored-by: Liam White <[email protected]> * Add remaining SSL modes Co-authored-by: Liam White <[email protected]> * Configure CNI (istio#68) * Configure CNI * review Signed-off-by: Liam White <[email protected]> * Add CNI config file name, used when chained is false Co-authored-by: Liam White <[email protected]> * Revert "Postgres SSL settings (istio#67)" (istio#70) * Revert "Postgres SSL settings (istio#67)" This reverts commit 391889fdaf5bfa3996c85719975df1c44ce94102. * Add back all ssl modes * Doc Fixes for Install API (istio#71) * ci: Add check (istio#73) This patch brings the check script to release-0.8.0. Seems like this is the new "master". Signed-off-by: Dhi Aurrahman <[email protected]> * docs: Add types frontmatter (istio#74) This adds types frontmatter data to types.proto. Until we have an automated way to populate title, we are encouraged to add a title when it is desired. Signed-off-by: Dhi Aurrahman <[email protected]> * Postgres SSL mode default to require (istio#75) * Autogen JSON shims (istio#80) * nits * Update install readme (istio#85) * Add ES version to settings (istio#88) * Add ES version to settings * ES version int with validation Co-authored-by: Liam White <[email protected]> Co-authored-by: Dhi Aurrahman <[email protected]> Co-authored-by: Vikas Choudhary (vikasc) <[email protected]> Co-authored-by: Marc Cirauqui <[email protected]> This PR merges the release_0.8.0 (as of commit - d3a19fdd8d25cdd8f386c4a4a2a821daa9865df0) branch into master. operator protos needs go_plugin instead of gogofast_plugin for the protoc. It is as is merge otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have a mix of descriptors that reflect our current thinking when they were created. As a result, we have a slew of different styles. We've settled on the style used by the MetricDescriptor (the QuotaDescriptor standardized on this), the rest of the descriptors need to be brought up to date.
The text was updated successfully, but these errors were encountered: