new conf design — typography #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saihaj
reviewed
Apr 28, 2025
| .typography-h2 { | ||
| font-size: 32px; | ||
| } | ||
| @media (min-width: 768px) { |
There was a problem hiding this comment.
should we use the tailwind breakpoints here?
There was a problem hiding this comment.
great minds ^^
I should probably rebase it to make it cleaner tho
hasparus
force-pushed
the
new-conf-design--colors
branch
from
c9f0a87 to
a263043
Compare
hasparus
force-pushed
the
new-conf-design--typography
branch
from
2d2be97 to
9890b09
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 15, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I mirrored the text styles from Figma. https://www.figma.com/design/aPUvZDSxJfYDJtPd7GF2sB/GraphQL.org?node-id=54-1194&m=dev
I need to applaud the designers for the most consistent use of typography I've seen. Usually people fiddle with the font size per each breakpoint until it feels right resulting in styles like
text-base sm:text-lg md:text-sm lg:text-2xl.