new conf design — fonts #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saihaj
reviewed
Apr 28, 2025
| @@ -28,7 +23,7 @@ export default function RootLayout({ | |||
| children: ReactNode | |||
| }): ReactElement { | |||
| return ( | |||
| <html lang="en" className={`scroll-smooth ${font.className}`}> | |||
| <html lang="en" className="scroll-smooth"> | |||
There was a problem hiding this comment.
I suppose we still need <OldFonts/> applied to the rest of the pages like the blog
There was a problem hiding this comment.
The blog is in Pages router / Nextra 3, so it still has the font in _app.tsx.
Uri told me I can spend a moment refactoring this and migrating libraries, but... I just don't wanna do it yet. Let's get this conf website up, and then we can think about bumping Tailwind and unifying the routers, and doing whatever else
I kinda aligned on @kamilkisiela's opinion on SSG metaframeworks after reading some newest changelogs.
hasparus
force-pushed
the
new-conf-design--fonts
branch
from
efabe54 to
4b08c52
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Commit Mono and Host Grotesk.
This PR touches the older conference websites because there was previously a global on HTML.
I moved to using a custom CSS properties
--font-sansand--font-mono, so it's easier to avoid conflicts and usage offont-sansfrom Tailwind doesn't override the global font.