Skip to content

[skip changelog] Fix platform loading legacy tests #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2021

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Updates some legacy tests that didn't respect the documentation. Also clarifies the documentation regarding platform.local.txt and boards.local.txt.

  • What is the current behavior?

Legacy tests uncorrectly load platform.local.txt and boards.local.txt from folders that don't contain a platform.txt or boards.txt.

  • What is the new behavior?

Legacy tests now reflect the current loading behaviour of installed platforms.

Nope.

  • Other information:

Fixes #1172


See how to contribute

@silvanocerza silvanocerza added topic: documentation Related to documentation for the project component/core labels Feb 10, 2021
@silvanocerza silvanocerza self-assigned this Feb 10, 2021
@silvanocerza silvanocerza force-pushed the scerza/fix-legacy-platforms-loading branch from 5509724 to 384052a Compare February 11, 2021 11:38
@silvanocerza
Copy link
Contributor Author

Rebased to include integration tests fixes from #1183

@silvanocerza silvanocerza force-pushed the scerza/fix-legacy-platforms-loading branch from 384052a to 1171b0e Compare February 11, 2021 13:56
@silvanocerza silvanocerza merged commit 0e6bb9e into master Feb 11, 2021
@silvanocerza silvanocerza deleted the scerza/fix-legacy-platforms-loading branch February 11, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the legacy package not handling correctly the loading of platforms
2 participants