Skip to content

[skip changelog] Fix integration tests not deleting folders when test finishes #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Feb 11, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes integration tests failing on CI.

  • What is the current behavior?

Folders used by integration tests are not deleted, this causes disk space filling up in the CI and make it fail.

  • What is the new behavior?

Folders are now deleted when they reach the end of their scope. This way the disk space won't fill up and the CI won't fail.

Nope.

  • Other information:

I actually thought that this was already done with #943 but turns out that I commented out the folders removal. 🤦


See how to contribute

@silvanocerza
Copy link
Contributor Author

All checks are clear, PR approved, merging and rebasing failing PRs on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants