Skip to content

Fix the legacy package not handling correctly the loading of platforms #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silvanocerza opened this issue Feb 5, 2021 · 0 comments · Fixed by #1180
Closed

Fix the legacy package not handling correctly the loading of platforms #1172

silvanocerza opened this issue Feb 5, 2021 · 0 comments · Fixed by #1180
Assignees

Comments

@silvanocerza
Copy link
Contributor

silvanocerza commented Feb 5, 2021

Right now the legacy package handle the loading of platforms, both those installed via the CLI or the IDE, and those installed manually in the sketchbook hardware folder.

As of now manually installed platforms are unversioned, meaning the platform.txt version property is not parsed. Unversioned platforms have their version string set to "".

This causes some issues to implement some new features, like the core list --all command to list all installed and installable cores, so we want to read the version when loading the manually installed cores too.

The platforms documentation specifies that name and version properties must be set so we can be sure that they'll be there and can be read.

With #1166 I tried to introduce the --all flag for core list command but it caused some issues in the legacy packaged, since the tests were expecting an unversioned library they broke.

The way they broke made me notice that certain tests on the legacy package are not respecting the platforms documentation, since they work even if the platform.local.txt and the boards.local.txt are not stored at the same directory level as their counterparts platform.txt and boards.txt.

We must fix the tests in the legacy package so that the local.txt files are where they must be as per documentation and update the hardware loading accordingly if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants