-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
add multiple language selection #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add Translation part in Readme
merge from master
@bebraw Please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so two things right off the bat:
- The build is failing because you can't
import
a stylesheet within antwar's<Interactive>
component. I know you're not using<Interactive>
directly but theNavigation
component is. You'll have move theimport './drop-down-style';
into theSite
component (where you'll see a bunch of other style imports. - Also, did you test this on the mid-range breakpoint (from 768 to 1024)? The main navigation section is already a bit crowded and I have a feeling adding another large link will either break the layout or make things look even more tight. I've been giving this some thought since you opened the issue and I think a tighter menu like this or this (maybe using abbreviations instead of flags) would be the right approach.
Once the import
is resolved and we discuss the layout I'd be happy to do a fuller review/test. If need be, I can definitely help with this to get it across the finish line. Aside from the points I mentioned there's a few other design tweaks I might make but that can be done in a separate PR.
@bebraw @sokra @TheLarkInn @lcxfs1991 also, from a higher level, how does internationalization play out in terms of issue management, prs, etc? I know right now there's a |
Local translation branch is for a separate management just like webpack-china since we have to fetch plugin/loader readme and put them under I think we can try locki. But we need to ensure the performance and we'd better keep a local copy of data. We can then compare two approaches, locki or webpack-china, and decide which one we should pick up for localization. |
@lcxfs1991 ah ok thanks for the clarification, I did see something about that in #722 I think. In terms of the getting this PR merged please see my comments above. @bebraw any reason we can't just keep that change in the master branch? I actually kind of like having all site content, including fetched content, in the |
Let me fix this tonight. |
Ok great, no rush. |
merge from master
@skipjack pls check. |
@lcxfs1991 awesome work, I will review again (and hopefully merge) shortly! |
Preview:
Fixes #966