merge from master #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lcxfs1991
commented
Apr 23, 2017
lcxfs1991
commented
- Read and sign the CLA. This needs to be done only once. PRs that haven't signed it won't be accepted.
- Make sure your PR complies with the writer's guide.
- Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.
- Remove these instructions from your PR as they are for your eyes only.
Tiny spelling correction
Update output.md
Add Translation part in Readme
Compiler event hook is `failed`, not `fail`.
I started just fixing the outstanding "and" in "Donations are always welcome and Open Collective" and ended up cleaning the list of bullet points (make sure each point starts with a verb, etc.). It's all writing style so no offense taken if changes not accepted ;-) Love this page btw!
Update "How Can I Help?"
* refactor: clean up lint scripts and remove `lint:md` The `lint:md` command isn't very semantic as it stands right now and also isn't very useful. We'd have to split out a separate eslint config for this and even then it might be hard to strike a nice balance. * fix: update markdownlint configuration and fix a bunch of errors * fix: resolve alex warnings by allowing a wider range of words * fix: format all config files consistently * refactor: reformat proselintrc after editorconfig changes * fix: update `deploy.sh` to run all test scripts
no need to pass here since we have commonConfig(), useless params
remove useless env param
Clarify output.strictModuleExceptionHandling
code-splitting: add new webpack 2.4.0 features
Document new options in webpack 2.3.0
Sidebar: show vertical bar for items w/o anchors
instructions to install css-loader in "Code Splitting - CSS"
Consistent `npm install --save-dev`
Rename markdownlint config file. This enables syntax highlighting, and the VS Code extension `markdownlint` to pick up the file.
Rename to .markdownlint.json
package.json: Remove obsolete dependencies
refactor: create `.github` directory to contain all github-specific files Closes #1136.
* Create a .github/. Move allowed templates inside. Closes #1136. * Move CONTRIBUTING.md -> .github * 💄 Global editor configs for prettier diffs!
* Keep introduction for fetched content * Rewrite loader/plugin links * Only rewrite links to repository home
docs(guides): improve "Code Splitting - CSS" guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.