Revert remove tuple keydef #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ligurio
force-pushed
the
ligurio/revert-remove-tuple-keydef
branch
from
dcc6b15 to
c8fb9e7
Compare
ligurio
force-pushed
the
ligurio/revert-remove-tuple-keydef
branch
2 times, most recently
from
5a2f899 to
2303735
Compare
|
The motivation: we decided to don't shrink the set of supported tarantool version in the upcoming release and deliver new features first. |
|
We should do something with the red CI. Ideally, implement tarantool/setup-tarantool#15 and use it here. I have a draft patch for this setup-tarantool issue, hopefully I'll show it on the week. |
ligurio
force-pushed
the
ligurio/revert-remove-tuple-keydef
branch
18 times, most recently
from
ada7bf5 to
845cd27
Compare
Totktonada
approved these changes
Oct 19, 2021
olegrok
approved these changes
Oct 19, 2021
LGTM |
This reverts commit 56247f2. We will remove support of Tarantool version a bit later.
This reverts commit 5edf027. We will remove support of Tarantool version a bit later.
We need a version 1.10.6 in testing because it has no tuple-keydef and tuple-merger support and we can test our own implementation of both modules on that version. However Tarantool EE 1.10.6 is not available for installation anymore, so we will use Tarantool CE 1.10.6 as a replacement. Luarocks in Tarantool 1.10.6 has a bug [1], so we need to apply a patch [2] with fix for tarantool's luarocks file before using `tarantoolctl rock`. 1. tarantool/tarantool#4704 2. tarantool/luarocks@eb555fa
ligurio
force-pushed
the
ligurio/revert-remove-tuple-keydef
branch
from
845cd27 to
1150e5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done? Why? What problem is being solved?
I didn't forget about
Closes #???