-
Notifications
You must be signed in to change notification settings - Fork 15
Describe supported Tarantool versions with limitations #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d1d1f57
to
1cf734f
Compare
d9f8ac3
to
df83166
Compare
df83166
to
c77247b
Compare
@Totktonada gentle reminder |
README.md
Outdated
- 1.10: since 1.10.7-91-g9ee14eca5 with tuple-merger<sup>1</sup> and | ||
tuple-keydef<sup>2</sup> modules, without UUID keys comparison and without | ||
Jsonpath indexes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see information about minimal tarantool version I can use with crud. It generally works without keydef and merger (built-in or external), correct? So, say, I can use it on 1.10.3 if I don't want JSON path indexes, UUID, decimal and sorting by a collation different than 'unicode' or 'unicode_ci'. Correct?
After PR #198 this rule splits to two:
- For all functions except min/max, <..as stated above..>.
- For min / max there is additional requirement <...>.
The compatibility guarantees were changed and I want to know how exactly. Any formal unambiguous form to present this information is okay.
c77247b
to
46999e4
Compare
46999e4
to
140e7a5
Compare
0c4ef33
to
cb17e8e
Compare
What is the reason to make so big information noise on the first Readme lines? |
For those who interested to dig to a topic himself I recommend to start with: - search using of helper functions like utils.tarantool_supports_* in source code base - search conditions with `_TARANTOOL` in source codebase - supported Tarantool versions by tuple-keydef module [1] - supported Tarantool versions by tuple-merger module [2] - source code for compatibility layer in CRUD - "Select: support jsonpath indexes (#158)" (27d825f) - JSON paths support in Tarantool [3] - release notes 1. https://github.com/tarantool/tuple-keydef#compatibility 2. https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees 3. https://www.tarantool.io/en/doc/latest/reference/reference_lua/json_paths/ 4. https://www.tarantool.io/en/doc/latest/release/
Update and upsert: support JSON paths Update: allow update absent nullable fields 1. tarantool/tarantool#1261 2. tarantool/tarantool#3378
References 1. Differences from the built-in merger module - https://github.com/tarantool/tuple-merger#backward-and-forward-compatibility-guarantees 2. Differences from the built-in key_def module - https://github.com/tarantool/tuple-keydef#differences-from-the-built-in-module
4052104
to
7226ff7
Compare
@filonenko-mikhail There are many different point of views how it looks in a README. Yours is only one of these. I think that a first question which should be answered here is "why and who does need such information in a readme?" and then it should be easier to answer to yours question. CRUD depends on different Tarantool features that were supported in different Tarantool versions. We decided to describe what CRUD features works on tarantool versions and how good this support is. Imagine you are tarantool's user and you want to start using crud on tarantool 1.10, but you dont' want to upgrade a major version. In such case you may go to our table and read that CRUD supports Tarantool since 1.10.7, it doesn't have uuid keys comparison support and doesn't have UUID support. Looks as a useful information for CRUD's users. This information available as an additional section in the README.
|
What is the plan to support such information up to date? |
What has been done? Why? What problem is being solved?
I didn't forget about
TestsDocumentationCloses #217