Skip to content

Update Tarantool versions in test matrix #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Conversation

ligurio
Copy link
Member

@ligurio ligurio commented Aug 14, 2021

Tarantool 2.8.1 [1] and Tarantool 2.9 are available [2], let's include
it to test matrix. Test
simple_operations[memtx].test_intermediate_nullable_fields_update has
failed on 2.8 [3] and to crash looks similar to a bug described in [4].
Testcase skipped on 2.8 to workaround it before next release.

Tarantool 2.4-6 has reached EOL, so these version has been removed from
test matrix.

  1. https://github.com/tarantool/tarantool/releases/tag/2.8.1
  2. https://github.com/tarantool/tarantool/releases/tag/2.9.0
  3. https://github.com/tarantool/crud/pull/195/checks?check_run_id=3320469716
  4. SEGFAULT on update nullable fields tarantool#6069

What has been done? Why? What problem is being solved?

I didn't forget about

  • Tests
  • Changelog
  • Documentation

Closes #???

@ligurio ligurio marked this pull request as draft August 14, 2021 21:50
@ligurio ligurio mentioned this pull request Aug 14, 2021
3 tasks
@ligurio ligurio force-pushed the ligurio/update_test_matrix branch 2 times, most recently from d25eb14 to 907b2f3 Compare August 16, 2021 07:55
@ligurio ligurio requested a review from olegrok August 16, 2021 07:55
@ligurio ligurio marked this pull request as ready for review August 16, 2021 07:56
@ligurio ligurio force-pushed the ligurio/update_test_matrix branch from 907b2f3 to 8a197e8 Compare August 16, 2021 07:59
@ligurio
Copy link
Member Author

ligurio commented Aug 16, 2021

@Totktonada, could you mark testing for Tarantool 2.{4,5,6} as not required in repository settings to make CI green?

@ligurio ligurio force-pushed the ligurio/update_test_matrix branch from 8a197e8 to 8817d5d Compare September 1, 2021 07:26
@Totktonada
Copy link
Member

@Totktonada, could you mark testing for Tarantool 2.{4,5,6} as not required in repository settings to make CI green?

Done.

@ligurio ligurio force-pushed the ligurio/update_test_matrix branch 4 times, most recently from 0df1863 to 38c584b Compare September 1, 2021 12:06
@ligurio ligurio force-pushed the ligurio/update_test_matrix branch from 38c584b to 3236202 Compare September 1, 2021 12:55
Tarantool 2.8.2 [1] is available, let's include it to test matrix.
Tarantool 2.4-6 has reached EOL, so these version has been removed from
test matrix.

1. https://github.com/tarantool/tarantool/releases/tag/2.8.2
tuple-keydef built in Tarantool since 1.10.7 [1] and CRUD has a source
code to make it compatible with Tarantools with and without tuple-keydef
module, see 'Fix compatibility with old Tarantool versions' 7413c6a.
Now 1.10.6 is gone, it is removed from test matrix and there are no
reasons to keep compatibility code.

1. https://github.com/tarantool/tuple-keydef#compatibility
@ligurio ligurio force-pushed the ligurio/update_test_matrix branch from 3236202 to 5209ea5 Compare September 1, 2021 13:10
@ligurio ligurio merged commit 56247f2 into master Sep 1, 2021
@ligurio ligurio deleted the ligurio/update_test_matrix branch September 1, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants