[5.10] Fix non-tarballed SDK installation with remote URL (#7312) #7321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation: 4714ea9 introduced a regression where non-tarball SDKs could not be installed from a remote URL due to the wrong assumption that the downloaded file would always be a tarball. This issue exists in 5.10 release branch, so will cherry-pick after merging this PR. ### Modifications: This commit fixes the issue by checking the file extension part of the URL for every supported archive format, then falling back to the tarball format if no supported extension is found. ### Result: Non-tarball SDK artifact bundles can be installed from remote URL.
kateinoigakukun
requested review from
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci Please test |
|
@kateinoigakukun would you mind adding a filled in form to the PR description with Explanation/Scope/Risk/Testing etc fields matching recent 5.10 PRs, like this one for example? #7308 |
MaxDesiatov
added
bug
cross-compilation
swift 5.10
|
Gentle ping :) |
|
Unfortunately, it doesn't look this will make it in time for 5.10.0 as the bar for that is very high. It may still be eligible for subsequent patch 5.10.x releases if those happen, so I'll keep this PR open for now. |
|
@swift-ci test |
airspeedswift
approved these changes
Mar 19, 2024
MaxDesiatov
previously approved these changes
Mar 19, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
MaxDesiatov
dismissed
their stale review
We need to hold off merging this unfortunately for a bit more time. There are infrastructure changes requires for this to land correctly post 5.10.0
12 tasks
MaxDesiatov
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍒 #7312
swift experimental-sdkcommand, which is still experimental. Also doesn't impact other binaries or SwiftPM clients/libraries.