Skip to content

[5.10] Gate new tests on supportsSDKDependentTests() #7308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

neonichu
Copy link
Contributor

@neonichu neonichu commented Jan 30, 2024

(cherry picked from commit 8bc47da)

  • Explanation:

We have been seeing flakiness of tests requiring the SDK (e.g. compiling manifests or running tests) for quite some time on the smoke test macOS CI. Some new tests were recently added which fall under this category but haven't been marked with the appropriate skipping clauses.

@neonichu neonichu added the swift 5.10 This PR targets the 5.10 branch label Jan 30, 2024
@neonichu neonichu self-assigned this Jan 30, 2024
@neonichu
Copy link
Contributor Author

@swift-ci please test

@neonichu
Copy link
Contributor Author

@swift-ci please test windows

@neonichu
Copy link
Contributor Author

Hm, this doesn't look like flakiness to me? Potentially Windows CI doesn't work anymore for 5.10?

CMake Error at C:/Users/swift-ci/jenkins/workspace/swiftpm-PR-windows/swift/cmake/modules/SwiftComponents.cmake:126 (message):
  unknown install component: swift-external-generic-metadata-builder
Call Stack (most recent call first):
  C:/Users/swift-ci/jenkins/workspace/swiftpm-PR-windows/swift/CMakeLists.txt:803 (swift_configure_components)


-- Configuring incomplete, errors occurred!
See also "T:/0/CMakeFiles/CMakeOutput.log".
See also "T:/0/CMakeFiles/CMakeError.log".
Error: cmake.exe exited with code 1.

@neonichu
Copy link
Contributor Author

@swift-ci please test windows

1 similar comment
@neonichu
Copy link
Contributor Author

@swift-ci please test windows

@bnbarham bnbarham self-requested a review February 1, 2024 01:07
@shahmishal shahmishal merged commit 4af9bb2 into release/5.10 Feb 1, 2024
@shahmishal shahmishal deleted the gate-on-supportsSDKDependentTests-5.10 branch February 1, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
swift 5.10 This PR targets the 5.10 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants