Add support for Generic Node Sensor Edition by TTI #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update 13 octuber 2020
Update 23 diciembre 2020
Update 22 jul
Update 7/08/2021
fpistm
requested changes
Aug 10, 2021
There was a problem hiding this comment.
Thanks @sabas1080 for this PR
I've made some fixes, cosmetic and rename the variant to be more precise than simply Generic Node.
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_GENERIC_NODE.cpp
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_GENERIC_NODE.cpp
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_GENERIC_NODE.h
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_GENERIC_NODE.h
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_GENERIC_NODE.h
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_GENERIC_NODE.h
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_GENERIC_NODE.cpp
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/variant_GENERIC_NODE.cpp
Outdated
Show resolved
Hide resolved
variants/STM32WLxx/WL54CCU_WL55CCU_WLE4C(8-B-C)U_WLE5C(8-B-C)U/ldscript.ld
Outdated
Show resolved
Hide resolved
fpistm
requested changes
Aug 11, 2021
There was a problem hiding this comment.
Hi @sabas1080 and @Liars126
I could not push on your branch so please update your PR like this one:
https://github.com/fpistm/Arduino_Core_STM32/tree/generic_node_SE
I've fixed some issues, do some cosmetic and add the linked generic variants.
About your issue with I2C, it seems there is no PU resistors for I2C lines. You can try to redefine the I2C peripheral pins array to enable the PU.
fpistm
requested changes
Aug 12, 2021
sabas1080
force-pushed
the
generic_node_ttn
branch
from
9aaed24 to
49cfeb4
Compare
fpistm
changed the title
fpistm
changed the title
fpistm
approved these changes
Aug 13, 2021
fpistm
added a commit
that referenced
this pull request
Aug 13, 2021
Add support for Generic Node Sensor Edition by TTI
|
@sabas1080 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fpistm
I am working to add support to Generic Node Sensor Edition by TTI, I have received a piece of hardware, at the moment the basic support is ready
Thanks