Fix spring-orm tests with eclipselink and Java 18+ #31078
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Fix kotlin scripts compatibility with jre 19+ Closes spring-projectsgh-30648 Signed-off-by: Dmitrii Bocharov <[email protected]>
Fix spring-orm tests with eclipselink for jre 18+ Closes spring-projectsgh-30648 Signed-off-by: Dmitrii Bocharov <[email protected]>
sdeleuze
added
status: invalid
|
actually, that's why i made 2 commits. I can remove the one for kotlin fixes |
|
Let's have a look to the other commit indeed. |
snicoll
changed the title
snicoll
removed
status: invalid
spring-projects-issues
added
the
status: waiting-for-triage
|
Unfortunately, we can't change the dependency of Eclipselink like that as we need to build against 3.0 to match our JPA 3.0 / EE 9 baseline. We should probably see if we can change the dependency when the tests run with Java 21. |
snicoll
added
status: declined
|
However, @jhoeller pointed out that Eclipselink |
snicoll
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Oct 24, 2023
snicoll
added a commit
that referenced
this pull request
Oct 24, 2023
We can't upgrade to Eclipselink 4 as it would change the baseline that this generation uses. However, there is a recent release in the current line that adds compatibility with recent JDKs. See gh-31078
bclozel
added a commit
that referenced
this pull request
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.