Skip to content

Enable KotlinScriptTemplateTests with Java 20 #30896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Jul 15, 2023

This PR changes to enable the KotlinScriptTemplateTests with Java 20 as 66a1be2 says that Java 21 is not supported and ./gradlew :spring-webflux:test -PtestToolchain=20 --tests KotlinScriptTemplateTests seems to work with this change.

See gh-29249

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 15, 2023
@sbrannen sbrannen added type: task A general task theme: kotlin An issue related to Kotlin support labels Jul 15, 2023
@sbrannen sbrannen self-assigned this Jul 15, 2023
@sbrannen sbrannen added this to the 6.1.0-M3 milestone Jul 15, 2023
@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Jul 15, 2023
@sbrannen sbrannen changed the title Enable KotlinScriptTemplateTests with Java 20 Enable KotlinScriptTemplateTests with Java 20 Jul 15, 2023
@sbrannen sbrannen closed this in be8bfad Jul 15, 2023
@sbrannen
Copy link
Member

Good catch! 👍

Though you missed KotlinScriptTemplateTests in spring-webmvc.

No worries, I updated that in 0611192.

@izeye izeye deleted the gh-29249-follow-on branch July 15, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: kotlin An issue related to Kotlin support type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants