Skip to content

persistent spike lines and axis labelling on multi-plots #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

slawlor
Copy link
Owner

@slawlor slawlor commented Jun 12, 2020

This PR supports adding persistent spike lines on click on charts. This way, in multi-plot charts, you can see the pinned spike line across all charts as you drag & zoom in other charts.

Additionally we added missing sub-labels on multi plots so the xaxis labels can be replicated on each subsequent plot if wished.

Apologies, but I cannot identify the maintainers except for @archmoj. If you would prefer other reviewers please let me know or link them to the PR. This is related to issue plotly#4052 in plotly/plotly.js and plotly#2539 as well

@slawlor slawlor self-assigned this Jun 15, 2020
@slawlor
Copy link
Owner Author

slawlor commented Jun 15, 2020

Also tagging @etpinard as a potential reviewer

@slawlor slawlor closed this Oct 11, 2023
@Glopter
Copy link

Glopter commented Oct 11, 2023

@slawlor This would be a great feature. Why did you close this PR?

@slawlor
Copy link
Owner Author

slawlor commented Oct 11, 2023

Because it had been 3 years with no activity lol. I was cleaning up my GitHub account is all

@Glopter
Copy link

Glopter commented Oct 11, 2023

Fair enough. It's a shame that the mills here grind so slowly. I would have loved to see this feature in production.

@slawlor
Copy link
Owner Author

slawlor commented Oct 11, 2023

Fair enough. It's a shame that the mills here grind so slowly. I would have loved to see this feature in production.

If you have better luck with the plotly maintainers, please feel free to comandeer the changeset and try and get them to review it! Would love to see it merged eventually, but I don't have great hope unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants