chore: update toolchain #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
changed the title
This reverts commit ab2c19d.
Merged
hero78119
pushed a commit
that referenced
this pull request
Oct 4, 2024
I extracted these changes from #309 to make that PR's diff smaller and thus easier to review. The changes were suggested by the new version of clippy.
matthiasgoergens
changed the title
At least those warnings that show up when running ``` cargo check --workspace --exclude ceno_rt --exclude singer-pro ```
Instead of whitelisting a few packages to run clippy on, we just blacklist the two where it's not expected to work.
… matthias/clippy-everywhere
… matthias/clippy-everywhere
matthiasgoergens
force-pushed
the
matthias/toolchain-2024-10
branch
from
0a54936 to
69c76b8
Compare
naure
approved these changes
Oct 15, 2024
| wrap_comments = false | ||
| comment_width = 300 | ||
| imports_granularity = "Crate" | ||
| max_width = 100 | ||
| newline_style = "Unix" | ||
| normalize_comments = true | ||
| reorder_imports = true |
There was a problem hiding this comment.
This is now the default anyway.
| @@ -122,15 +122,6 @@ impl<E: ExtensionField> Circuit<E> { | |||
| let mut input_paste_from_consts_in = Vec::new(); | |||
| let mut max_in_wit_num_vars: Option<usize> = None; | |||
| for (ty, in_cell_ids) in in_cell_ids.iter() { | |||
| #[cfg(feature = "debug")] | |||
There was a problem hiding this comment.
@naure I removed this, because clippy complained that we don't actually have a debug feature, and when I moved to using #[cfg(debug_assertions)] instead, I noticed that the code here is actually broken and doesn't compile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
rust-toolchainspecifiesnightly-2024-05-02. That one comes withrustfmtversion 1.7. But ourrustfmt.tomlusesstyle_edition = "2024"; but2024was only added in version 1.8. So in this PR we update to a more recent nightly toolchain.Most of the changes in here are from our specified
rustfmt.tomlconfig actually applying. The main thing that's causing a lot of diff is version sorting of imports, which changes how letter case is handled for comparison.Fixes #297
I extracted some clippy suggestions into #318 to make this PR smaller.