Skip to content

Mixing up toolchain versions? #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthiasgoergens opened this issue Oct 2, 2024 · 1 comment · Fixed by #309
Closed

Mixing up toolchain versions? #297

matthiasgoergens opened this issue Oct 2, 2024 · 1 comment · Fixed by #309

Comments

@matthiasgoergens
Copy link
Contributor

matthiasgoergens commented Oct 2, 2024

Our rust-toolchain specifies nightly-2024-05-02. That one comes with rustfmt version 1.7. But our rustfmt.toml uses style_edition = "2024"; but 2024 was only added in version 1.8.

Is this mix-up intentional?

There are multiple ways to fix this: update the nightly that we are using, or change what options we specify. Or: just ignore the issues altogether.

Updating the nightly is presumably something we want to do eventually anyway, but it also comes with wider consequences.

Just to be clear: this is a very low priority issue. I'm just going through configuration and warnings as part of my ritual to explore a new code base. So feel free to ignore this.

@matthiasgoergens

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant