-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Emit inline errors at expansion site #7684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolasstucki
merged 5 commits into
scala:master
from
dotty-staging:emit-inline-errors-at-expansion-site
Dec 5, 2019
Merged
Emit inline errors at expansion site #7684
nicolasstucki
merged 5 commits into
scala:master
from
dotty-staging:emit-inline-errors-at-expansion-site
Dec 5, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccc6aa3
to
8a2198b
Compare
This will also fix #7442 |
smarter
reviewed
Dec 4, 2019
0316d8c
to
02efa27
Compare
Needs to be rebased |
02efa27
to
bb8642e
Compare
Rebased |
anatoliykmetyuk
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
Co-Authored-By: Anatolii Kmetiuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more informative for users of an inline (or macro) method. It also avoids trying to load sources from libraries to show the position.