Skip to content

Emit inline errors at expansion site #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Dec 4, 2019

This is more informative for users of an inline (or macro) method. It also avoids trying to load sources from libraries to show the position.

@nicolasstucki nicolasstucki self-assigned this Dec 4, 2019
@nicolasstucki nicolasstucki force-pushed the emit-inline-errors-at-expansion-site branch from ccc6aa3 to 8a2198b Compare December 4, 2019 18:14
@nicolasstucki
Copy link
Contributor Author

This will also fix #7442

@nicolasstucki nicolasstucki force-pushed the emit-inline-errors-at-expansion-site branch from 0316d8c to 02efa27 Compare December 5, 2019 07:51
@nicolasstucki nicolasstucki marked this pull request as ready for review December 5, 2019 09:25
@nicolasstucki
Copy link
Contributor Author

Needs to be rebased

@nicolasstucki nicolasstucki force-pushed the emit-inline-errors-at-expansion-site branch from 02efa27 to bb8642e Compare December 5, 2019 10:09
@nicolasstucki
Copy link
Contributor Author

Rebased

Copy link
Contributor

@anatoliykmetyuk anatoliykmetyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants