Fix #7618: Remove QuoteContext.macroContext #7681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an old context that was synthesized for macros before we used implicit function types within splices to provide the context.
nicolasstucki
force-pushed
the
remove-QuoteContext-macro-context
branch
from
963fdbd to
ac9660a
Compare
nicolasstucki
changed the title
nicolasstucki
commented
Dec 4, 2019
| object Compiler { | ||
| import Exp._ | ||
|
|
||
| inline def compile(e: Exp, env: Map[String, Expr[Int]])(given ctx: QuoteContext): Expr[Int] = inline e match { // error |
There was a problem hiding this comment.
This may conflict with #7684. One of the PRs needs to be rebased on the other one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an old context that was synthesized for macros before we used implicit function types within splices to provide the context.