Add community build: Intent #7437
Conversation
|
|
Looks like we're emitting invalid classfile names on windows., |
|
Sorry, I made an incorrect assumption about the error you posted, but the API of tasty reflect has changed since [info] Set current project to intent (in build file:/Users/jamie/Workspace/dotty/community-build/community-projects/intent/)
[info] Forcing Scala version to 0.20.0-bin-SNAPSHOT on all projects.
[info] Reapplying settings...
[info] Set current project to intent (in build file:/Users/jamie/Workspace/dotty/community-build/community-projects/intent/)
[info] Updating macros...
[info] Done updating.
[info] Updating ...
[info] Done updating.
[info] Compiling 1 Scala source to /Users/jamie/Workspace/dotty/community-build/community-projects/intent/macros/target/scala-0.20/classes ...
[error] -- [E008] Member Not Found Error: /Users/jamie/Workspace/dotty/community-build/community-projects/intent/macros/src/main/scala/intent/macros/source.scala:54:28
[error] 54 | val file = rootPosition.sourceFile
[error] | ^^^^^^^^^^^^^^^^^^^^^^^
[error] | value sourceFile is not a member of qctx.tasty.Position
[error] -- [E008] Member Not Found Error: /Users/jamie/Workspace/dotty/community-build/community-projects/intent/macros/src/main/scala/intent/macros/source.scala:56:35
[error] 56 | val lineNo: Int = rootPosition.startLine
[error] | ^^^^^^^^^^^^^^^^^^^^^^
[error] | value startLine is not a member of qctx.tasty.Position
[error] -- [E008] Member Not Found Error: /Users/jamie/Workspace/dotty/community-build/community-projects/intent/macros/src/main/scala/intent/macros/source.scala:57:34
[error] 57 | val colNo: Int = rootPosition.startColumn
[error] | ^^^^^^^^^^^^^^^^^^^^^^^^
[error] | value startColumn is not a member of qctx.tasty.Position
[error] three errors found
[error] (macros / Compile / compileIncremental) Compilation failed
[error] Total time: 3 s, completed 19-Oct-2019 19:06:19
[error] Test dotty.communitybuild.CommunityBuildTest.intent failed: java.lang.AssertionError:
[error]
[error] sbt exited with an error code. To reproduce without JUnit, use:
[error]
[error] sbt community-build/prepareCommunityBuild
[error] cd community-build/community-projects/intent
[error] sbt -sbt-version 1.2.7 --addPluginSbtFile=/Users/jamie/Workspace/dotty/community-build/sbt-dotty-sbt ";clean ;set updateOptions in Global ~= (_.withLatestSnapshots(false)) ;++0.20.0-bin-SNAPSHOT! test"
[error]
[error] For a faster feedback loop, one can try to extract a direct call to dotc
[error] using the sbt export command. For instance, for scalacheck, use
[error] sbt export jvm/test:compileIncremental
[error]
[error] , took 36.458 sec
[error] at dotty.communitybuild.CommunityBuildTest.test(CommunityBuildTest.scala:84)
[error] at dotty.communitybuild.CommunityBuildTest.intent(CommunityBuildTest.scala:209)
[error] ... |
|
@bishabosha are there replacements for those members already in 0.19.0? Otherwise I won't be able to make the changes just yet. |
|
Or do you mean the recommendation is to make a community-build branch in Intent that builds against latest Dotty? |
|
So you should be able to make a forwards compatible change by replacing |
|
We should always use a branch in our own fork, that way if we break something, we can fix it without waiting for it to be fixed upstream, which would force us to temporarily disable the broken project in our CI. |
|
Ok, makes sense. However, the |
|
Im closing this because I made a fork in dotty-staging that has a separate PR |
Intent is a test framework for Dotty: https://github.com/factor10/intent. @bishabosha suggested I should add it as a community build.
Two things:
It is not clear to me whether the test command should run tests or just compile (or test-compile). The existing projects differ in this regard.
I don't know if this PR works. When I run
sbt community-build/test, I get:Any suggestions to get past the error?