Fix #6902: Avoid illegal characters for generated given names #6903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Name encoding does not kick in automatically for operator symbols which appear in a prefix of a name, so the name `<<<_of_A_given` was kept as is, which is problematic since `<` is not valid in method names on the JVM (in `i6902.scala`, `<<<<` runs fine even before this change, because monomorphic givens are implemented as objects, not defs). Having to remember to call `avoidIllegalChars` isn't great, but fixing that should be part of a bigger refactoring of name mangling we still need to do: scala#5936.
smarter
force-pushed
the
fix-given-encoding
branch
from
0484364 to
f1a777b
Compare
odersky
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name encoding does not kick in automatically for operator symbols which
appear in a prefix of a name, so the name
<<<_of_A_givenwas kept asis, which is problematic since
<is not valid in method names on theJVM (in
i6902.scala,<<<<runs fine even before this change, becausemonomorphic givens are implemented as objects, not defs).
Having to remember to call
avoidIllegalCharsisn't great, but fixingthat should be part of a bigger refactoring of name mangling we still
need to do: #5936.