Deny warnings in CI (except for nightly channel) #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed on the first commit of this PR because there were warnings that need to be fixed. This was the desired result. I've now added another commit to fix the warnings, so CI should pass. |
jturner314
force-pushed
the
deny-warnings-in-ci
branch
from
c6eecb8 to
c7a1ca3
Compare
|
I'd say it makes to limit it to CI - merging 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to read in #661 that there are warnings that we haven't fixed. This PR makes the build fail if there are any compiler warnings, except on the nightly channel.
It's tempting to add
#![deny(warnings)]to the top oflib.rs, but when working onndarray, I don't really want warnings to get in the way of development. So, I'm proposing just denying warnings in CI.