Skip to content

ArcArray1 #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
max-sixty opened this issue Jul 18, 2019 · 4 comments · Fixed by #741
Closed

ArcArray1 #661

max-sixty opened this issue Jul 18, 2019 · 4 comments · Fixed by #741
Labels
enhancement good first issue A good issue to start contributing to ndarray!

Comments

@max-sixty
Copy link
Contributor

There are some references to RcArray1 & RcArray2, causing some warnings. I was planning to put in a PR to move these to ArcArray, but ArcArray1 doesn't exist.

Should we create them? Or move specializations up a level?
@LukeMathWalker
Copy link
Member

In the end, it's syntactic sugar and I think we should keep them (if nothing else, for consistency with Array1, ArrayView1, etc.). What do you mean by moving specializations up a level?

@max-sixty
Copy link
Contributor Author

Should we create ArcArray1 & ArcArray2? Currently we only have a deprecated RcArray1 & RcArray2

@LukeMathWalker
Copy link
Member

Yes, I think we should.

@LukeMathWalker LukeMathWalker added enhancement good first issue A good issue to start contributing to ndarray! labels Jul 20, 2019
@max-sixty
Copy link
Contributor Author

max-sixty commented Jul 28, 2019 •
edited
Loading

@alex179ohm if you're looking for a good issue to begin with, this could be interesting

@jturner314 jturner314 mentioned this issue Aug 2, 2019
Merged
@LukeMathWalker LukeMathWalker mentioned this issue Aug 5, 2019
Open
31 tasks
@danieledapo danieledapo mentioned this issue Oct 7, 2019
Merged
@bluss bluss closed this as completed in #741 Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue A good issue to start contributing to ndarray!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add ArcArray1 and ArcArray2 aliases
2 participants
@max-sixty @LukeMathWalker