-
Notifications
You must be signed in to change notification settings - Fork 44
Allow to pass registry ssh key #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for the PR! The code changes look good, but I'm worried about the extensibility of the API, as git2 supports more authentication methods than just in-memory SSH keys. I think the most extensible solution would be to make the use rustwide::{AlternativeRegistry, Crate};
let mut registry = AlternativeRegistry::new("https://github.com/rust-lang/crates.io-index");
registry.authenticate_with_ssh_key("key");
let krate = Crate::registry(®istry, "name", "version"); |
Oh, it seems I missed a notification for that thread, sorry for that.
UPD: it seems current changes are breaking anyway due to new |
Sounds good! We're also pre-1.0 on rustwide, so it's fine to make breaking changes, especially to make the API easier to extend in the future! |
@pietroalbini I think this is waiting on your review. |
I'm currently working with cloudsmith.io, which will only support git credentials. We're configuring our own image to get around this, but want to see if this method could support adding to .git-credentials on the image as well. |
Sorry for the late merge, will release this soon! |
Released rustwide 0.15.0 with this change. |
* using the changes from Byron/crates-index-diff-rs#15 * also upgrades `rustwide` and `git2` since `crates-index-diff` the includes release includes an update of `libgit2` * adaptions due to `rustwide` changes in rust-lang/rustwide#65
* using the changes from Byron/crates-index-diff-rs#15 * also upgrades `rustwide` and `git2` since `crates-index-diff` the includes release includes an update of `libgit2` * adaptions due to `rustwide` changes in rust-lang/rustwide#65
* using the changes from Byron/crates-index-diff-rs#15 * also upgrades `rustwide` and `git2` since `crates-index-diff` the includes release includes an update of `libgit2` * adaptions due to `rustwide` changes in rust-lang/rustwide#65
No description provided.