refactor logic to handle crate-deletes

[syphar]

sometimes crates are deleted completely by the crates.io team. This can be due to security issues (rustdecimal is a current example), DCMA or GDPR requests.

In docs.rs we're using this library and I want to handle crate deletes automatically when crates.io deletes the crate from the index.

I'm aware this is a breaking change, though I'm not sure how this could look like in a compatible change.

I'm OK if you don't want to break the API, then I would create a fork or copy the needed code over to the docs.rs repo.

[Byron]

Thanks a lot for your contribution, it's very much appreciated! Breaking changes are generally fine and I don't think there is any need for holding back here.

I will create the new release shortly.

[…] then I would create a fork or copy the needed code over to the docs.rs repo.

Since docs.rs critically depends on this repository and since I wrote this crate specifically for the purpose of serving docs.rs, you might want to consider to either take ownership or add some team-members as collaborators. The same could be true for crates.io ownership. Please note that I do have plans with this crate as eventually it should be migrated to gitoxide, so whatever ownership model you come up with, ideally that will still be possible for me.

[Byron]

The new release is now available.

[syphar]

[…] then I would create a fork or copy the needed code over to the docs.rs repo.

Since docs.rs critically depends on this repository and since I wrote this crate specifically for the purpose of serving docs.rs, you might want to consider to either take ownership or add some team-members as collaborators. The same could be true for crates.io ownership. Please note that I do have plans with this crate as eventually it should be migrated to gitoxide, so whatever ownership model you come up with, ideally that will still be possible for me.

coming from @jyn514 ( from the docs.rs channel on discord)

I think it makes sense for the docs.rs team to be maintainers, yes. I wonder if we should invite Byron to the docs.rs team. He's been very helpful and it would simplify the ownership for that crate.

At the least I also would help maintaining the crate, depending on the potential docs.rs ownership also more.

[Byron]

I wonder if we should invite Byron to the docs.rs team.

I would be honored! But even if not I can transfer ownership of this crate or at least add collaborators. Just let me know what works best and it can be done.

[jyn514]

@Byron amazing! The way to join is by making a PR to https://github.com/rust-lang/team - add yourself to ./people and your username to https://github.com/rust-lang/team/blob/9de1895b14f7515b4bc53a682628de01f8ca0cf6/teams/docs-rs.toml#L6. It would also be great if you could join the official discord server, which is where we communicate: https://discord.gg/f7mTXPW

[Byron]

🎉! Alright, here is my PR to join the team.

I also joined the discord channel but will probably not receive notifications when pinged as I can't download the discord phone app from my location. I will see all pings on GitHub though.