Skip to content

E0422 description. #28554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2015
Merged

E0422 description. #28554

merged 1 commit into from
Oct 2, 2015

Conversation

alexispurslane
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

apasel422
apasel422 reviewed Sep 20, 2015
View reviewed changes
src/librustc_typeck/diagnostics.rs
```

In this case, `Foo` is undefined, so it inherently isn't anything, and
definatly not a struct.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/definatly/definitely/

@alexispurslane
Copy link
Contributor Author

Thanks, @apasel422! (I also squashed the commits.)

@apasel422
Copy link
Contributor

@ChristopherDumas Should this be in librustc_resolve/diagnostics.rs instead?

@alexispurslane
Copy link
Contributor Author

I don't know.

@apasel422
Copy link
Contributor

git grep E0422 indicates the the error originates from that file, so presumably yes.

@alexispurslane
Copy link
Contributor Author

Yeah, your right.

@alexispurslane
Copy link
Contributor Author

I squashed the commits again.

@apasel422
Copy link
Contributor

You'll also have to remove line 914.

@alexispurslane
Copy link
Contributor Author

Whoops! OK.

apasel422
apasel422 reviewed Sep 20, 2015
View reviewed changes
src/librustc_resolve/diagnostics.rs
@@ -888,7 +911,7 @@ register_diagnostics! {
E0418, // is not an enum variant, struct or const
E0420, // is not an associated const
E0421, // unresolved associated const
E0422, // does not name a structure
// E0422, // does not name a structure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete it, rather than comment it out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK? Is that better? I noticed that some are commented out, while some are deleted.

@apasel422
Copy link
Contributor

That's better. The ones that are commented out are commented out instead of deleted in order to ensure that no one uses them in the future (because they apply to errors that no longer exist).

@arielb1
Copy link
Contributor

arielb1 commented Oct 1, 2015

@bors r+ rollup a818f9f

@bors
Copy link
Collaborator

bors commented Oct 1, 2015

📌 Commit a818f9f has been approved by arielb1

@bors
Copy link
Collaborator

bors commented Oct 1, 2015

⌛ Testing commit a818f9f with merge 48a24bf...

@bors
Copy link
Collaborator

bors commented Oct 1, 2015

💔 Test failed - auto-win-msvc-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Oct 1, 2015 at 9:26 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-msvc-64-opt
http://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt/builds/1569

—
Reply to this email directly or view it on GitHub
#28554 (comment).

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Oct 1, 2015
@steveklabnik
Rollup merge of rust-lang#28554 - christopherdumas:E0422, r=arielb1
eb90af8
@steveklabnik steveklabnik mentioned this pull request Oct 1, 2015
Closed
bors added a commit that referenced this pull request Oct 2, 2015
@bors
Auto merge of #28798 - steveklabnik:rollup, r=steveklabnik
ef3fe25 
- Successful merges: #28554, #28686, #28786, #28788, #28791, #28797
- Failed merges:
Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 2, 2015
@Manishearth
Rollup merge of rust-lang#28554 - christopherdumas:E0422, r=arielb1
b1d2a49
@Manishearth Manishearth mentioned this pull request Oct 2, 2015
Merged
bors added a commit that referenced this pull request Oct 2, 2015
@bors
Auto merge of #28807 - Manishearth:rollup, r=Manishearth
70076ec 
- Successful merges: #28554, #28686, #28786, #28788, #28791, #28797
- Failed merges:
@bors bors merged commit a818f9f into rust-lang:master Oct 2, 2015
@alexispurslane alexispurslane deleted the E0422 branch September 12, 2016 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexispurslane @rust-highfive @apasel422 @arielb1 @bors @alexcrichton