Skip to content

Pattern matching on newtype structs doesn't work cross crate #6086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pcwalton opened this issue Apr 27, 2013 · 2 comments
Closed

Pattern matching on newtype structs doesn't work cross crate #6086

pcwalton opened this issue Apr 27, 2013 · 2 comments
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically

Comments

@pcwalton
Copy link
Contributor

How embarrassing.
@luqmana
Copy link
Member

luqmana commented Apr 29, 2013

I have a patch which fixes this by just adding def_fn to a few match patterns but it seems a bit hacky. I'm not sure why resolve treats newtype structs as def_fn instead of def_struct as it does when not cross crate.

@luqmana luqmana mentioned this issue Apr 30, 2013
Closed
bors added a commit that referenced this issue Apr 30, 2013
@bors
auto merge of #6121 : luqmana/rust/newtype-cc, r=graydon
c081ffb 
#6086
@luqmana
Copy link
Member

luqmana commented Apr 30, 2013

Fixed by #6121.

@luqmana luqmana closed this as completed Apr 30, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 6, 2020
@bors
Auto merge of rust-lang#6086 - Ryan1729:add-suspicious_chained_operat…
7a73a25 
…ors-lint, r=llogiq

Add suspicious_operation_groupings lint

This is my (<del> currently WIP </del>) attempt to close rust-lang#6039.

changelog: Added `suspicious_operation_groupings` lint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcwalton @luqmana