Skip to content

Task local storage leaks memory #6039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Apr 24, 2013 · 5 comments
Closed

Task local storage leaks memory #6039

brson opened this issue Apr 24, 2013 · 5 comments
Assignees
@brson
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows

Comments

@brson
Copy link
Contributor

brson commented Apr 24, 2013

The recent conversion from reinterpret_cast to transmute introduced a memory leak to TLS. It does not reveal itself though because the box annihilator happily destroys the leaked boxes. In my branch, newsched has TLS but does not have the annihilator, so I'm seeing leaks.

Took all afternoon to figure that out. I'll have a fix soon.
@ghost ghost assigned brson Apr 24, 2013
brson added a commit to brson/rust that referenced this issue Apr 24, 2013
@brson
core: Convert reinterpret_cast to transmute in TLS. rust-lang#6039
6373861
@brson
Copy link
Contributor Author

brson commented May 11, 2013

Fixed

@brson brson closed this as completed May 11, 2013
@brson brson reopened this May 11, 2013
@brson
Copy link
Contributor Author

brson commented May 11, 2013

I'm not sure this has landed.

@Aatch
Copy link
Contributor

Aatch commented May 11, 2013

This has landed now.

@graydon graydon closed this as completed May 11, 2013
@graydon graydon reopened this May 11, 2013
@graydon
Copy link
Contributor

graydon commented May 11, 2013

@Aatch Can you point to the revision? These are helpful for tackling down regressions.

@emberian
Copy link
Member

@graydon seems to be in 0.7: 6373861

flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 6, 2020
@bors
Auto merge of rust-lang#6086 - Ryan1729:add-suspicious_chained_operat…
7a73a25 
…ors-lint, r=llogiq

Add suspicious_operation_groupings lint

This is my (<del> currently WIP </del>) attempt to close rust-lang#6039.

changelog: Added `suspicious_operation_groupings` lint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@graydon @brson @Aatch @emberian