-
Notifications
You must be signed in to change notification settings - Fork 88
Use fabs intrinsic #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
29996be
to
06814be
Compare
...Why do these tests pass locally but fail on GH? |
dunno but the code itself looks good. |
I just tried this on my machine (AMD) and it also passed. |
Oh wait, I rebased and ran it in release mode and it failed. Anyway, I found the problem. Look at what asm is generated for
|
wait |
It always returns false :) |
always finite but never normal around here, apparently. :^) |
Opened rust-lang/rust#84268 and #97. |
I posted it in the linked issue, but this looks like an LLVM 12 regression |
06814be
to
9acc112
Compare
I noticed there's a
simd_fabs
even though there is nosimd_abs
.Same story as #89.