Skip to content

Use neg intrinsics #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Use neg intrinsics #89

merged 1 commit into from
Apr 17, 2021

Conversation

workingjubilee
Copy link
Member

simd_neg was added in rust-lang/rust#83271 so now we get to use it.
This PR fixes #32.

@calebzulawski
Copy link
Member

It looks like this is failing on wasm+simd?

Error: failed to deserialize wasm module

Caused by:
    0: failed to parse code section
    1: Unknown 0xfd opcode (at offset 576984)
error: test failed, to rerun pass '--test i16_ops'
Error: Running Wasm tests with wasm-bindgen-test failed
Caused by: failed to execute `cargo test`: exited with exit code: 1
  full command: "cargo" "test" "--release" "--target" "wasm32-unknown-unknown"
The command "wasm-pack test --chrome --headless crates/core_simd --release" exited with 1.

0xfd are the SIMD opcodes. Not sure if this is a bug in LLVM or chrome

@workingjubilee
Copy link
Member Author

workingjubilee commented Apr 9, 2021

One way to help tell would be to add the ability to test against wasmtime and/or Firefox SIMD for reference.

@calebzulawski
Copy link
Member

I wonder if something broke in chrome, since #83 is failing for the same reason.

@workingjubilee workingjubilee mentioned this pull request Apr 14, 2021
@calebzulawski calebzulawski merged commit e73985f into master Apr 17, 2021
@workingjubilee workingjubilee deleted the intrinsic-neg branch April 17, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace bitxor in float Neg impl with an intrinsic
3 participants