refactor(theme/book): Split into modules #556
Conversation
|
This looks great! Ran this on RBE, not seeing issues so far...
This is a bit confusing (maybe even alarming) to me. |
|
There was no need for them to be let in the first place, since they are constants. |
|
Yes, we can fix all that up in a different PR. LGTM, would probably be best if another person also pulls this down and checks for issues, though. |
|
All of the empty lines have an extra space on them. |
|
@sorin-davidoi, #557 is fixed now so if you rebase onto This looks like it's ready to merge, although you'll probably want to clean up the whitespace issue @Havvy mentioned first. |
Advantages: - Easier to reason about - Can easily disable some modules when debugging - Shared dependencies are explicit (playpen_text) - Enables some fancier things later one (e.g. run `codeSnippets` slightly later, to avoid blocking the page) I'm aware that `codeSnippets` should be split into the highlighter and the editor, but I'm not sure I understand exactly how they interact so I've left it as it is for now.
Advantages: - Easier to reason about - Can easily disable some modules when debugging - Shared dependencies are explicit (playpen_text) - Enables some fancier things later one (e.g. run `codeSnippets` slightly later, to avoid blocking the page) I'm aware that `codeSnippets` should be split into the highlighter and the editor, but I'm not sure I understand exactly how they interact so I've left it as it is for now.
Advantages:
codeSnippetsslightly later, to avoid blocking the page)I'm aware that
codeSnippetsshould be split into the highlighter and the editor, but I'm not sure I understand exactly how they interact so I've left it as it is for now.Also replaced some occurences ofletwithvar(for consistency).Closes #559.