Rethink book.js organization #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

budziq opened this issue Jun 23, 2017 · 1 comment

Labels

A-JavaScript C-refactor M-Discussion

Contributor

budziq commented Jun 23, 2017

As discussed in https://github.com/azerupi/mdBook/pull/338#discussion_r123618836

Discussion points:

Consider splitting book.js by feature
- Separate into smaller js files included in index.hbs?
- book.js generated like index.hbs?
Consider switching to TypeScript for type safety.
- Adds dependency on TypeScript compiler
- Slightly harder to start contribution for newcommers

budziq mentioned this issue

Ace editor #338

Merged

azerupi added A-JavaScript M-Discussion C-refactor labels

Contributor

sorin-davidoi commented Feb 7, 2018

In #556 book.js was split into modules, but they are still in one file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment