Track when crates are yanked and handle yanked status better #739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @QuietMisdreavus :) |
Nemo157
force-pushed
the
bop-it-twist-it-yank-it
branch
from
0cea556 to
4c9a2e6
Compare
jyn514
reviewed
May 1, 2020
| @@ -180,11 +183,11 @@ impl CrateDetails { | |||
| description: rows.get(0).get(4), | |||
| rustdoc_status: rows.get(0).get(11), | |||
| target_name: rows.get(0).get(16), | |||
| default_target: rows.get(0).get(25), | |||
| default_target: rows.get(0).get(26), | |||
There was a problem hiding this comment.
Oh boy, we have some technical debt stacking up. Once this PR is in I think we should start think about getting things by name instead of by index: https://docs.rs/postgres/0.15.2/postgres/rows/struct.Row.html#method.get
src/web/rustdoc.rs
Outdated
Comment on lines
849
to
854
| use html5ever::tendril::TendrilSink; | ||
| assert_success(path, web)?; | ||
| let data = web.get(path).send()?.text()?; | ||
| Ok(kuchiki::parse_html() | ||
| .one(data) | ||
| .select("form ul li .warn") |
There was a problem hiding this comment.
get_platform_links is pretty similar to this, do you think it's worth factoring out a html_select() function?
Kixiron
reviewed
May 1, 2020
jyn514
reviewed
May 1, 2020
Nemo157
force-pushed
the
bop-it-twist-it-yank-it
branch
4 times, most recently
from
a07a4e4 to
c6298d6
Compare
jyn514
reviewed
May 6, 2020
src/docbuilder/queue.rs
Outdated
Comment on lines
31
to
32
| .ok(); | ||
| debug!("{}-{} yanked", krate.name, krate.version); |
Comment on lines
+1333
to
+1336
| assert_eq!( | ||
| env.frontend().get("/crate/dummy").send()?.status(), | ||
| StatusCode::NOT_FOUND | ||
| ); |
There was a problem hiding this comment.
Suggested change
| assert_eq!( | |
| env.frontend().get("/crate/dummy").send()?.status(), | |
| StatusCode::NOT_FOUND | |
| ); | |
| assert_eq!( | |
| env.frontend().get("/crate/dummy").send()?.status(), | |
| StatusCode::NOT_FOUND | |
| ); | |
| assert_eq!( | |
| env.frontend().get("/dummy").send()?.status(), | |
| StatusCode::NOT_FOUND | |
| ); |
|
Whoops, I misread the changes. You addressed both the comments I linked. |
|
Looks good once nits have been addressed. |
Nemo157
force-pushed
the
bop-it-twist-it-yank-it
branch
2 times, most recently
from
8e15b27 to
3f855ec
Compare
…link go direct to crate page on build failure
Nemo157
force-pushed
the
bop-it-twist-it-yank-it
branch
from
3f855ec to
d51802c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I skipped 7a57350 from #322 to avoid any conflicts with #721, it may be useful to look into rebasing that too later.
fixes #112, #396
closes #322
Screenshots:
nav bar when viewing latest version and all versions are yanked:
nav bar when there's at least one non-yanked version, or viewing non-latest version of a fully yanked crate:
crate details page:
crate details version list:
crate details nav drop-down:
